Commit abaf00ff authored by Oliver Neukum's avatar Oliver Neukum Committed by David S. Miller

usb: hso: remove bogus check for EINPROGRESS

This check an inherent race. It opens a race where
an error code has already been set or cleared yet
the URB has not been given back. We cannot do
such an optimization and must unlink unconditionally.
Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 11c5f6d2
...@@ -831,8 +831,7 @@ static void hso_net_tx_timeout(struct net_device *net, unsigned int txqueue) ...@@ -831,8 +831,7 @@ static void hso_net_tx_timeout(struct net_device *net, unsigned int txqueue)
dev_warn(&net->dev, "Tx timed out.\n"); dev_warn(&net->dev, "Tx timed out.\n");
/* Tear the waiting frame off the list */ /* Tear the waiting frame off the list */
if (odev->mux_bulk_tx_urb && if (odev->mux_bulk_tx_urb)
(odev->mux_bulk_tx_urb->status == -EINPROGRESS))
usb_unlink_urb(odev->mux_bulk_tx_urb); usb_unlink_urb(odev->mux_bulk_tx_urb);
/* Update statistics */ /* Update statistics */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment