Commit ac0e94b6 authored by Colin Ian King's avatar Colin Ian King Committed by Matt Fleming

x86/efi: Initialize status to ensure garbage is not returned on small size

Although very unlikey, if size is too small or zero, then we end up with
status not being set and returning garbage. Instead, initializing status to
EFI_INVALID_PARAMETER to indicate that size is invalid in the calls to
setup_uga32 and setup_uga64.
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: default avatarMatt Fleming <matt@codeblueprint.co.uk>
parent dce48e35
...@@ -578,7 +578,7 @@ setup_uga32(void **uga_handle, unsigned long size, u32 *width, u32 *height) ...@@ -578,7 +578,7 @@ setup_uga32(void **uga_handle, unsigned long size, u32 *width, u32 *height)
efi_guid_t uga_proto = EFI_UGA_PROTOCOL_GUID; efi_guid_t uga_proto = EFI_UGA_PROTOCOL_GUID;
unsigned long nr_ugas; unsigned long nr_ugas;
u32 *handles = (u32 *)uga_handle;; u32 *handles = (u32 *)uga_handle;;
efi_status_t status; efi_status_t status = EFI_INVALID_PARAMETER;
int i; int i;
first_uga = NULL; first_uga = NULL;
...@@ -623,7 +623,7 @@ setup_uga64(void **uga_handle, unsigned long size, u32 *width, u32 *height) ...@@ -623,7 +623,7 @@ setup_uga64(void **uga_handle, unsigned long size, u32 *width, u32 *height)
efi_guid_t uga_proto = EFI_UGA_PROTOCOL_GUID; efi_guid_t uga_proto = EFI_UGA_PROTOCOL_GUID;
unsigned long nr_ugas; unsigned long nr_ugas;
u64 *handles = (u64 *)uga_handle;; u64 *handles = (u64 *)uga_handle;;
efi_status_t status; efi_status_t status = EFI_INVALID_PARAMETER;
int i; int i;
first_uga = NULL; first_uga = NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment