Commit af4b3a71 authored by Michal Vokáč's avatar Michal Vokáč Committed by Bartlomiej Zolnierkiewicz

video: ssd1307fb: Do not hard code active-low reset sequence

The SSD130x OLED display reset signal is active low. Now the reset
sequence is implemented in such a way that users are forced to
define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work.

Do not hard code the active-low sequence into the driver but instead
allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect
the real world.
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
Signed-off-by: default avatarMichal Vokáč <michal.vokac@ysoft.com>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
parent 7d7e58d3
...@@ -667,10 +667,10 @@ static int ssd1307fb_probe(struct i2c_client *client, ...@@ -667,10 +667,10 @@ static int ssd1307fb_probe(struct i2c_client *client,
if (par->reset) { if (par->reset) {
/* Reset the screen */ /* Reset the screen */
gpiod_set_value_cansleep(par->reset, 0);
udelay(4);
gpiod_set_value_cansleep(par->reset, 1); gpiod_set_value_cansleep(par->reset, 1);
udelay(4); udelay(4);
gpiod_set_value_cansleep(par->reset, 0);
udelay(4);
} }
if (par->vbat_reg) { if (par->vbat_reg) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment