Commit b049aadc authored by Danny Kukawka's avatar Danny Kukawka Committed by David S. Miller

3com/typhoon: reuse eth_mac_addr()

Use eth_mac_addr() for .ndo_set_mac_address, remove
typhoon_set_mac_address() since it do currently the same as
eth_mac_addr(). Additional advantage: eth_mac_addr() already
checks if the given address is valid.
Signed-off-by: default avatarDanny Kukawka <danny.kukawka@bisect.de>
Acked-by: default avatarDave Dillow <dave@thedillows.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f274fd9a
...@@ -966,18 +966,6 @@ typhoon_get_stats(struct net_device *dev) ...@@ -966,18 +966,6 @@ typhoon_get_stats(struct net_device *dev)
return stats; return stats;
} }
static int
typhoon_set_mac_address(struct net_device *dev, void *addr)
{
struct sockaddr *saddr = (struct sockaddr *) addr;
if(netif_running(dev))
return -EBUSY;
memcpy(dev->dev_addr, saddr->sa_data, dev->addr_len);
return 0;
}
static void static void
typhoon_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info) typhoon_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
{ {
...@@ -2266,7 +2254,7 @@ static const struct net_device_ops typhoon_netdev_ops = { ...@@ -2266,7 +2254,7 @@ static const struct net_device_ops typhoon_netdev_ops = {
.ndo_tx_timeout = typhoon_tx_timeout, .ndo_tx_timeout = typhoon_tx_timeout,
.ndo_get_stats = typhoon_get_stats, .ndo_get_stats = typhoon_get_stats,
.ndo_validate_addr = eth_validate_addr, .ndo_validate_addr = eth_validate_addr,
.ndo_set_mac_address = typhoon_set_mac_address, .ndo_set_mac_address = eth_mac_addr,
.ndo_change_mtu = eth_change_mtu, .ndo_change_mtu = eth_change_mtu,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment