Commit b05cd219 authored by Sakari Ailus's avatar Sakari Ailus Committed by Mauro Carvalho Chehab

[media] smiapp: Fix determining the need for 8-bit read access

8-bit reads are needed in some cases; however the condition used was wrong.
Regular access (register width) was used if:

	len == SMIAPP_REG_8BIT && !only8

This causes 8-bit read access to be used always. The operator should be ||
instead: regular access can be used for 8-bit reads OR if allowed otherwise.
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 6fcc7a52
...@@ -172,7 +172,7 @@ static int __smiapp_read(struct smiapp_sensor *sensor, u32 reg, u32 *val, ...@@ -172,7 +172,7 @@ static int __smiapp_read(struct smiapp_sensor *sensor, u32 reg, u32 *val,
&& len != SMIAPP_REG_32BIT) && len != SMIAPP_REG_32BIT)
return -EINVAL; return -EINVAL;
if (len == SMIAPP_REG_8BIT && !only8) if (len == SMIAPP_REG_8BIT || !only8)
rval = ____smiapp_read(sensor, (u16)reg, len, val); rval = ____smiapp_read(sensor, (u16)reg, len, val);
else else
rval = ____smiapp_read_8only(sensor, (u16)reg, len, val); rval = ____smiapp_read_8only(sensor, (u16)reg, len, val);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment