Skip to content

L
linux
Commit b08d2fb5 authored by Rob Herring's avatar Rob Herring Committed by Shawn Guo
Browse files
Options

ARM: dts: imx: Add missing #sound-dai-cells for sgtl5000 codec 

dtc now warns about missing #sound-dai-cells:

arch/arm/boot/dts/imx6ul-geam.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/imx6ul-isiot-emmc.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
arch/arm/boot/dts/imx6ul-isiot-nand.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])

Lots of i.MX boards use the SGTL5000 codec, but not all get the warning
because only some reference the codec with "sound-dai" property. However,
the codec should always provide #sound-dai-cells regardless, so fix all
the occurrences.

Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent cbeb1dc7
Hide whitespace changes
Inline Side-by-side
Showing with 14 additions and 0 deletions
arch/arm/boot/dts/imx28-apx4devkit.dts
View file @ b08d2fb5
...@@ -147,6 +147,7 @@ i2c0: i2c@80058000 { ...@@ -147,6 +147,7 @@ i2c0: i2c@80058000 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
VDDA-supply = <&reg_3p3v>; VDDA-supply = <&reg_3p3v>;
VDDIO-supply = <&reg_3p3v>; VDDIO-supply = <&reg_3p3v>;
clocks = <&saif0>; clocks = <&saif0>;
......
arch/arm/boot/dts/imx28-eukrea-mbmx28lc.dtsi
View file @ b08d2fb5
...@@ -151,6 +151,7 @@ &i2c0 { ...@@ -151,6 +151,7 @@ &i2c0 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
VDDA-supply = <&reg_3p3v>; VDDA-supply = <&reg_3p3v>;
VDDIO-supply = <&reg_3p3v>; VDDIO-supply = <&reg_3p3v>;
clocks = <&saif0>; clocks = <&saif0>;
......
arch/arm/boot/dts/imx28-evk.dts
View file @ b08d2fb5
...@@ -197,6 +197,7 @@ i2c0: i2c@80058000 { ...@@ -197,6 +197,7 @@ i2c0: i2c@80058000 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
VDDA-supply = <&reg_3p3v>; VDDA-supply = <&reg_3p3v>;
VDDIO-supply = <&reg_3p3v>; VDDIO-supply = <&reg_3p3v>;
clocks = <&saif0>; clocks = <&saif0>;
......
arch/arm/boot/dts/imx28-m28evk.dts
View file @ b08d2fb5
...@@ -140,6 +140,7 @@ i2c0: i2c@80058000 { ...@@ -140,6 +140,7 @@ i2c0: i2c@80058000 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
VDDA-supply = <&reg_3p3v>; VDDA-supply = <&reg_3p3v>;
VDDIO-supply = <&reg_3p3v>; VDDIO-supply = <&reg_3p3v>;
clocks = <&saif0>; clocks = <&saif0>;
......
arch/arm/boot/dts/imx51-babbage.dts
View file @ b08d2fb5
...@@ -369,6 +369,7 @@ &i2c2 { ...@@ -369,6 +369,7 @@ &i2c2 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
clocks = <&clk_audio>; clocks = <&clk_audio>;
VDDA-supply = <&vdig_reg>; VDDA-supply = <&vdig_reg>;
VDDIO-supply = <&vvideo_reg>; VDDIO-supply = <&vvideo_reg>;
......
arch/arm/boot/dts/imx53-m53evk.dts
View file @ b08d2fb5
...@@ -153,6 +153,7 @@ &i2c1 { ...@@ -153,6 +153,7 @@ &i2c1 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
VDDA-supply = <&reg_3p2v>; VDDA-supply = <&reg_3p2v>;
VDDIO-supply = <&reg_3p2v>; VDDIO-supply = <&reg_3p2v>;
clocks = <&clks IMX5_CLK_SSI_EXT1_GATE>; clocks = <&clks IMX5_CLK_SSI_EXT1_GATE>;
......
arch/arm/boot/dts/imx53-ppd.dts
View file @ b08d2fb5
...@@ -446,6 +446,7 @@ i2c4: i2c@0 { ...@@ -446,6 +446,7 @@ i2c4: i2c@0 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0xa>; reg = <0xa>;
#sound-dai-cells = <0>;
VDDA-supply = <&reg_sgtl5k>; VDDA-supply = <&reg_sgtl5k>;
VDDIO-supply = <&reg_sgtl5k>; VDDIO-supply = <&reg_sgtl5k>;
clocks = <&cko2_11M>; clocks = <&cko2_11M>;
......
arch/arm/boot/dts/imx53-qsb-common.dtsi
View file @ b08d2fb5
...@@ -317,6 +317,7 @@ &i2c2 { ...@@ -317,6 +317,7 @@ &i2c2 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
VDDA-supply = <&reg_3p2v>; VDDA-supply = <&reg_3p2v>;
VDDIO-supply = <&reg_3p2v>; VDDIO-supply = <&reg_3p2v>;
clocks = <&clks IMX5_CLK_SSI_EXT1_GATE>; clocks = <&clks IMX5_CLK_SSI_EXT1_GATE>;
......
arch/arm/boot/dts/imx53-tx53-x03x.dts
View file @ b08d2fb5
...@@ -230,6 +230,7 @@ &i2c3 { ...@@ -230,6 +230,7 @@ &i2c3 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
VDDA-supply = <&reg_2v5>; VDDA-supply = <&reg_2v5>;
VDDIO-supply = <&reg_3v3>; VDDIO-supply = <&reg_3v3>;
clocks = <&mclk>; clocks = <&mclk>;
......
arch/arm/boot/dts/imx53-tx53-x13x.dts
View file @ b08d2fb5
...@@ -131,6 +131,7 @@ &i2c3 { ...@@ -131,6 +131,7 @@ &i2c3 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
VDDA-supply = <&reg_2v5>; VDDA-supply = <&reg_2v5>;
VDDIO-supply = <&reg_3v3>; VDDIO-supply = <&reg_3v3>;
clocks = <&mclk>; clocks = <&mclk>;
......
arch/arm/boot/dts/imx53-voipac-bsb.dts
View file @ b08d2fb5
...@@ -133,6 +133,7 @@ &i2c3 { ...@@ -133,6 +133,7 @@ &i2c3 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
VDDA-supply = <&reg_3p3v>; VDDA-supply = <&reg_3p3v>;
VDDIO-supply = <&reg_3p3v>; VDDIO-supply = <&reg_3p3v>;
clocks = <&clks 150>; clocks = <&clks 150>;
......
arch/arm/boot/dts/imx6qdl-gw560x.dtsi
View file @ b08d2fb5
...@@ -288,6 +288,7 @@ &i2c2 { ...@@ -288,6 +288,7 @@ &i2c2 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
clocks = <&clks IMX6QDL_CLK_CKO>; clocks = <&clks IMX6QDL_CLK_CKO>;
VDDA-supply = <&reg_1p8v>; VDDA-supply = <&reg_1p8v>;
VDDIO-supply = <&reg_3p3v>; VDDIO-supply = <&reg_3p3v>;
......
arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
View file @ b08d2fb5
...@@ -196,6 +196,7 @@ pcf8523: rtc@68 { ...@@ -196,6 +196,7 @@ pcf8523: rtc@68 {
sgtl5000: codec@a { sgtl5000: codec@a {
clocks = <&clks IMX6QDL_CLK_CKO>; clocks = <&clks IMX6QDL_CLK_CKO>;
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
#sound-dai-cells = <0>;
pinctrl-names = "default"; pinctrl-names = "default";
pinctrl-0 = <&pinctrl_hummingboard2_sgtl5000>; pinctrl-0 = <&pinctrl_hummingboard2_sgtl5000>;
reg = <0x0a>; reg = <0x0a>;
......
arch/arm/boot/dts/imx6ul-geam.dts
View file @ b08d2fb5
...@@ -181,6 +181,7 @@ &i2c1 { ...@@ -181,6 +181,7 @@ &i2c1 {
sgtl5000: codec@a { sgtl5000: codec@a {
compatible = "fsl,sgtl5000"; compatible = "fsl,sgtl5000";
reg = <0x0a>; reg = <0x0a>;
#sound-dai-cells = <0>;
clocks = <&clks IMX6UL_CLK_OSC>; clocks = <&clks IMX6UL_CLK_OSC>;
clock-names = "mclk"; clock-names = "mclk";
VDDA-supply = <&reg_3p3v>; VDDA-supply = <&reg_3p3v>;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7