Commit b13c691e authored by David S. Miller's avatar David S. Miller Committed by David S. Miller

[PATCH] Warning fix

DEVICE_ID_SIZE clashes with the define in include/linux/device.h
parent 7c8f455e
...@@ -64,7 +64,7 @@ ...@@ -64,7 +64,7 @@
#define DRIVER_DESC "USB Printer Device Class driver" #define DRIVER_DESC "USB Printer Device Class driver"
#define USBLP_BUF_SIZE 8192 #define USBLP_BUF_SIZE 8192
#define DEVICE_ID_SIZE 1024 #define USBLP_DEVICE_ID_SIZE 1024
/* ioctls: */ /* ioctls: */
#define LPGETSTATUS 0x060b /* same as in drivers/char/lp.c */ #define LPGETSTATUS 0x060b /* same as in drivers/char/lp.c */
...@@ -839,7 +839,7 @@ static void *usblp_probe(struct usb_device *dev, unsigned int ifnum, ...@@ -839,7 +839,7 @@ static void *usblp_probe(struct usb_device *dev, unsigned int ifnum,
/* Malloc device ID string buffer to the largest expected length, /* Malloc device ID string buffer to the largest expected length,
* since we can re-query it on an ioctl and a dynamic string * since we can re-query it on an ioctl and a dynamic string
* could change in length. */ * could change in length. */
if (!(usblp->device_id_string = kmalloc(DEVICE_ID_SIZE, GFP_KERNEL))) { if (!(usblp->device_id_string = kmalloc(USBLP_DEVICE_ID_SIZE, GFP_KERNEL))) {
err("out of memory for device_id_string"); err("out of memory for device_id_string");
goto abort_minor; goto abort_minor;
} }
...@@ -1045,7 +1045,7 @@ static int usblp_cache_device_id_string(struct usblp *usblp) ...@@ -1045,7 +1045,7 @@ static int usblp_cache_device_id_string(struct usblp *usblp)
{ {
int err, length; int err, length;
err = usblp_get_id(usblp, 0, usblp->device_id_string, DEVICE_ID_SIZE - 1); err = usblp_get_id(usblp, 0, usblp->device_id_string, USBLP_DEVICE_ID_SIZE - 1);
if (err < 0) { if (err < 0) {
dbg("usblp%d: error = %d reading IEEE-1284 Device ID string", dbg("usblp%d: error = %d reading IEEE-1284 Device ID string",
usblp->minor, err); usblp->minor, err);
...@@ -1059,8 +1059,8 @@ static int usblp_cache_device_id_string(struct usblp *usblp) ...@@ -1059,8 +1059,8 @@ static int usblp_cache_device_id_string(struct usblp *usblp)
length = (usblp->device_id_string[0] << 8) + usblp->device_id_string[1]; length = (usblp->device_id_string[0] << 8) + usblp->device_id_string[1];
if (length < 2) if (length < 2)
length = 2; length = 2;
else if (length >= DEVICE_ID_SIZE) else if (length >= USBLP_DEVICE_ID_SIZE)
length = DEVICE_ID_SIZE - 1; length = USBLP_DEVICE_ID_SIZE - 1;
usblp->device_id_string[length] = '\0'; usblp->device_id_string[length] = '\0';
dbg("usblp%d Device ID string [len=%d]=\"%s\"", dbg("usblp%d Device ID string [len=%d]=\"%s\"",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment