Commit b1453d1e authored by Haibo Chen's avatar Haibo Chen Committed by Bartosz Golaszewski

gpio: pca953x: avoid logically dead code

The current code logic make the condition "else if (reg >= 0x54)"
can't be true, cause the dead code. So fix it to match the coder
expectation. This is reported by Coverity.

Fixes: 13c5d4ce ("gpio: pca953x: Add support for PCAL6534")
Signed-off-by: default avatarHaibo Chen <haibo.chen@nxp.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 29f5c6e6
......@@ -309,26 +309,26 @@ static bool pcal6534_check_register(struct pca953x_chip *chip, unsigned int reg,
int bank;
int offset;
if (reg >= 0x30) {
if (reg >= 0x54) {
/*
* Reserved block between 14h and 2Fh does not align on
* expected bank boundaries like other devices.
* Handle lack of reserved registers after output port
* configuration register to form a bank.
*/
int temp = reg - 0x30;
int temp = reg - 0x54;
bank = temp / NBANK(chip);
offset = temp - (bank * NBANK(chip));
bank += 8;
} else if (reg >= 0x54) {
bank += 16;
} else if (reg >= 0x30) {
/*
* Handle lack of reserved registers after output port
* configuration register to form a bank.
* Reserved block between 14h and 2Fh does not align on
* expected bank boundaries like other devices.
*/
int temp = reg - 0x54;
int temp = reg - 0x30;
bank = temp / NBANK(chip);
offset = temp - (bank * NBANK(chip));
bank += 16;
bank += 8;
} else {
bank = reg / NBANK(chip);
offset = reg - (bank * NBANK(chip));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment