Commit b1586f09 authored by Eric W. Biederman's avatar Eric W. Biederman Committed by David S. Miller

netpoll: Use skb_irq_freeable to make zap_completion_queue safe.

Replace the test in zap_completion_queue to test when it is safe to
free skbs in hard irq context with skb_irq_freeable ensuring we only
free skbs when it is safe, and removing the possibility of subtle
problems.
Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 574f7194
...@@ -270,7 +270,7 @@ static void zap_completion_queue(void) ...@@ -270,7 +270,7 @@ static void zap_completion_queue(void)
while (clist != NULL) { while (clist != NULL) {
struct sk_buff *skb = clist; struct sk_buff *skb = clist;
clist = clist->next; clist = clist->next;
if (skb->destructor) { if (!skb_irq_freeable(skb)) {
atomic_inc(&skb->users); atomic_inc(&skb->users);
dev_kfree_skb_any(skb); /* put this one back */ dev_kfree_skb_any(skb); /* put this one back */
} else { } else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment