Commit b1835d23 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Greg Kroah-Hartman

serial: 8250_dma: no need to set tx_err twice

In the serial8250_tx_dma() the tx_err flag is set in case of error. Thus, there
is no need to repeat this in __dma_tx_complete().
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2dc98946
...@@ -39,7 +39,6 @@ static void __dma_tx_complete(void *param) ...@@ -39,7 +39,6 @@ static void __dma_tx_complete(void *param)
ret = serial8250_tx_dma(p); ret = serial8250_tx_dma(p);
if (ret) { if (ret) {
dma->tx_err = 1;
p->ier |= UART_IER_THRI; p->ier |= UART_IER_THRI;
serial_port_out(&p->port, UART_IER, p->ier); serial_port_out(&p->port, UART_IER, p->ier);
} }
...@@ -93,7 +92,6 @@ int serial8250_tx_dma(struct uart_8250_port *p) ...@@ -93,7 +92,6 @@ int serial8250_tx_dma(struct uart_8250_port *p)
} }
dma->tx_running = 1; dma->tx_running = 1;
desc->callback = __dma_tx_complete; desc->callback = __dma_tx_complete;
desc->callback_param = p; desc->callback_param = p;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment