Commit b18a183e authored by Matwey V. Kornilov's avatar Matwey V. Kornilov Committed by Greg Kroah-Hartman

tty: serial: Use GFP_ATOMIC instead of GFP_KERNEL in serial8250_em485_init()

serial8250_em485_init() is supposed to be protected with
p->port.lock spinlock.
This may lead to issues when kmalloc sleeps, so it is better to use
GFP_ATOMIC in this spinlocked context.

Fixes: e490c914 ("tty: Add software emulated RS485 support for 8250")
Reported-by: default avatarИльяс Гасанов <torso.nafi@gmail.com>
Signed-off-by: default avatarMatwey V. Kornilov <matwey@sai.msu.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bf2a0be4
...@@ -588,7 +588,7 @@ int serial8250_em485_init(struct uart_8250_port *p) ...@@ -588,7 +588,7 @@ int serial8250_em485_init(struct uart_8250_port *p)
if (p->em485 != NULL) if (p->em485 != NULL)
return 0; return 0;
p->em485 = kmalloc(sizeof(struct uart_8250_em485), GFP_KERNEL); p->em485 = kmalloc(sizeof(struct uart_8250_em485), GFP_ATOMIC);
if (p->em485 == NULL) if (p->em485 == NULL)
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment