Commit b20b54fb authored by Cai Huoqing's avatar Cai Huoqing Committed by David S. Miller

net: stmmac: dwmac-visconti: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Acked-by: default avatarNobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3503e673
...@@ -171,10 +171,9 @@ static int visconti_eth_clock_probe(struct platform_device *pdev, ...@@ -171,10 +171,9 @@ static int visconti_eth_clock_probe(struct platform_device *pdev,
int err; int err;
dwmac->phy_ref_clk = devm_clk_get(&pdev->dev, "phy_ref_clk"); dwmac->phy_ref_clk = devm_clk_get(&pdev->dev, "phy_ref_clk");
if (IS_ERR(dwmac->phy_ref_clk)) { if (IS_ERR(dwmac->phy_ref_clk))
dev_err(&pdev->dev, "phy_ref_clk clock not found.\n"); return dev_err_probe(&pdev->dev, PTR_ERR(dwmac->phy_ref_clk),
return PTR_ERR(dwmac->phy_ref_clk); "phy_ref_clk clock not found.\n");
}
err = clk_prepare_enable(dwmac->phy_ref_clk); err = clk_prepare_enable(dwmac->phy_ref_clk);
if (err < 0) { if (err < 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment