Commit b28cc6ce authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Alexandre Belloni

rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'

In case of error, we return 0.
This is spurious and not consistent with the other functions of the driver.
Commit e115a2bf has modified more than what is said in the commit
message. Reverse part of it znd return an error when needed, as it was
previously.

Fixes: e115a2bf ("rtc: max77686: stop validating rtc_time in .read_time")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 50c8aec4
...@@ -360,7 +360,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm) ...@@ -360,7 +360,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm)
out: out:
mutex_unlock(&info->lock); mutex_unlock(&info->lock);
return 0; return ret;
} }
static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm) static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment