Commit b3ae2d35 authored by Volodymyr Mytnyk's avatar Volodymyr Mytnyk Committed by David S. Miller

net: prestera: flower: fix destroy tmpl in chain

Fix flower destroy template callback to release template
only for specific tc chain instead of all chain tempaltes.

The issue was intruduced by previous commit that introduced
multi-chain support.

Fixes: fa5d824c ("net: prestera: acl: add multi-chain support offload")
Signed-off-by: default avatarVolodymyr Mytnyk <vmytnyk@marvell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 36a29fb6
......@@ -12,18 +12,21 @@ struct prestera_flower_template {
u32 chain_index;
};
static void
prestera_flower_template_free(struct prestera_flower_template *template)
{
prestera_acl_ruleset_put(template->ruleset);
list_del(&template->list);
kfree(template);
}
void prestera_flower_template_cleanup(struct prestera_flow_block *block)
{
struct prestera_flower_template *template;
struct list_head *pos, *n;
struct prestera_flower_template *template, *tmp;
/* put the reference to all rulesets kept in tmpl create */
list_for_each_safe(pos, n, &block->template_list) {
template = list_entry(pos, typeof(*template), list);
prestera_acl_ruleset_put(template->ruleset);
list_del(&template->list);
kfree(template);
}
list_for_each_entry_safe(template, tmp, &block->template_list, list)
prestera_flower_template_free(template);
}
static int
......@@ -423,7 +426,14 @@ int prestera_flower_tmplt_create(struct prestera_flow_block *block,
void prestera_flower_tmplt_destroy(struct prestera_flow_block *block,
struct flow_cls_offload *f)
{
prestera_flower_template_cleanup(block);
struct prestera_flower_template *template, *tmp;
list_for_each_entry_safe(template, tmp, &block->template_list, list)
if (template->chain_index == f->common.chain_index) {
/* put the reference to the ruleset kept in create */
prestera_flower_template_free(template);
return;
}
}
int prestera_flower_stats(struct prestera_flow_block *block,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment