Commit b3c1afd1 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman

staging/lustre: fix return value check in libcfs_sock_ioctl()

In case of error, the function sock_alloc_file() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 49c02a75
...@@ -59,9 +59,9 @@ libcfs_sock_ioctl(int cmd, unsigned long arg) ...@@ -59,9 +59,9 @@ libcfs_sock_ioctl(int cmd, unsigned long arg)
} }
sock_filp = sock_alloc_file(sock, 0, NULL); sock_filp = sock_alloc_file(sock, 0, NULL);
if (!sock_filp) { if (IS_ERR(sock_filp)) {
sock_release(sock); sock_release(sock);
rc = -ENOMEM; rc = PTR_ERR(sock_filp);
goto out; goto out;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment