Commit b4d74f7a authored by Jérôme Pouiller's avatar Jérôme Pouiller Committed by Greg Kroah-Hartman

staging: wfx: reduce hold duration of cfg80211_bss

Pointer to cfg80211_bss is held during all duration of wfx_do_join. But,
it is not necessary, We can release it far earlier.
Signed-off-by: default avatarJérôme Pouiller <jerome.pouiller@silabs.com>
Link: https://lore.kernel.org/r/20200410133239.438347-3-Jerome.Pouiller@silabs.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0f66c31e
...@@ -509,6 +509,7 @@ static void wfx_do_join(struct wfx_vif *wvif) ...@@ -509,6 +509,7 @@ static void wfx_do_join(struct wfx_vif *wvif)
hif_set_block_ack_policy(wvif, 0xFF, 0xFF); hif_set_block_ack_policy(wvif, 0xFF, 0xFF);
wfx_set_mfp(wvif, bss); wfx_set_mfp(wvif, bss);
cfg80211_put_bss(wvif->wdev->hw->wiphy, bss);
ret = hif_join(wvif, conf, wvif->channel, ssid, ssidlen); ret = hif_join(wvif, conf, wvif->channel, ssid, ssidlen);
if (ret) { if (ret) {
...@@ -538,8 +539,6 @@ static void wfx_do_join(struct wfx_vif *wvif) ...@@ -538,8 +539,6 @@ static void wfx_do_join(struct wfx_vif *wvif)
wfx_update_filtering(wvif); wfx_update_filtering(wvif);
mutex_unlock(&wvif->wdev->conf_mutex); mutex_unlock(&wvif->wdev->conf_mutex);
if (bss)
cfg80211_put_bss(wvif->wdev->hw->wiphy, bss);
} }
static void wfx_unjoin_work(struct work_struct *work) static void wfx_unjoin_work(struct work_struct *work)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment