Commit b508d5fb authored by Josh Triplett's avatar Josh Triplett Committed by David S. Miller

net: ipconfig: Don't override command-line hostnames or domains

If the user specifies a hostname or domain name as part of the ip=
command-line option, preserve it and don't overwrite it with one
supplied by DHCP/BOOTP.

For instance, ip=::::myhostname::dhcp will use "myhostname" rather than
ignoring and overwriting it.

Fix the comment on ic_bootp_string that suggests it only copies a string
"if not already set"; it doesn't have any such logic.
Signed-off-by: default avatarJosh Triplett <josh@joshtriplett.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dd627662
...@@ -886,7 +886,7 @@ static void __init ic_bootp_send_if(struct ic_device *d, unsigned long jiffies_d ...@@ -886,7 +886,7 @@ static void __init ic_bootp_send_if(struct ic_device *d, unsigned long jiffies_d
/* /*
* Copy BOOTP-supplied string if not already set. * Copy BOOTP-supplied string
*/ */
static int __init ic_bootp_string(char *dest, char *src, int len, int max) static int __init ic_bootp_string(char *dest, char *src, int len, int max)
{ {
...@@ -935,12 +935,15 @@ static void __init ic_do_bootp_ext(u8 *ext) ...@@ -935,12 +935,15 @@ static void __init ic_do_bootp_ext(u8 *ext)
} }
break; break;
case 12: /* Host name */ case 12: /* Host name */
ic_bootp_string(utsname()->nodename, ext+1, *ext, if (!ic_host_name_set) {
__NEW_UTS_LEN); ic_bootp_string(utsname()->nodename, ext+1, *ext,
ic_host_name_set = 1; __NEW_UTS_LEN);
ic_host_name_set = 1;
}
break; break;
case 15: /* Domain name (DNS) */ case 15: /* Domain name (DNS) */
ic_bootp_string(ic_domain, ext+1, *ext, sizeof(ic_domain)); if (!ic_domain[0])
ic_bootp_string(ic_domain, ext+1, *ext, sizeof(ic_domain));
break; break;
case 17: /* Root path */ case 17: /* Root path */
if (!root_server_path[0]) if (!root_server_path[0])
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment