Commit b5155ddd authored by Wang Yufen's avatar Wang Yufen Committed by Jakub Kicinski

net: phy: Convert to use sysfs_emit() APIs

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the value
to be returned to user space.
Signed-off-by: default avatarWang Yufen <wangyufen@huawei.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/1664364860-29153-1-git-send-email-wangyufen@huawei.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 92346bde
...@@ -232,7 +232,7 @@ static ssize_t mdio_bus_stat_field_show(struct device *dev, ...@@ -232,7 +232,7 @@ static ssize_t mdio_bus_stat_field_show(struct device *dev,
val = mdio_bus_get_stat(&bus->stats[sattr->addr], val = mdio_bus_get_stat(&bus->stats[sattr->addr],
sattr->field_offset); sattr->field_offset);
return sprintf(buf, "%llu\n", val); return sysfs_emit(buf, "%llu\n", val);
} }
static ssize_t mdio_bus_device_stat_field_show(struct device *dev, static ssize_t mdio_bus_device_stat_field_show(struct device *dev,
...@@ -251,7 +251,7 @@ static ssize_t mdio_bus_device_stat_field_show(struct device *dev, ...@@ -251,7 +251,7 @@ static ssize_t mdio_bus_device_stat_field_show(struct device *dev,
val = mdio_bus_get_stat(&bus->stats[addr], sattr->field_offset); val = mdio_bus_get_stat(&bus->stats[addr], sattr->field_offset);
return sprintf(buf, "%llu\n", val); return sysfs_emit(buf, "%llu\n", val);
} }
#define MDIO_BUS_STATS_ATTR_DECL(field, file) \ #define MDIO_BUS_STATS_ATTR_DECL(field, file) \
......
...@@ -522,7 +522,7 @@ phy_id_show(struct device *dev, struct device_attribute *attr, char *buf) ...@@ -522,7 +522,7 @@ phy_id_show(struct device *dev, struct device_attribute *attr, char *buf)
{ {
struct phy_device *phydev = to_phy_device(dev); struct phy_device *phydev = to_phy_device(dev);
return sprintf(buf, "0x%.8lx\n", (unsigned long)phydev->phy_id); return sysfs_emit(buf, "0x%.8lx\n", (unsigned long)phydev->phy_id);
} }
static DEVICE_ATTR_RO(phy_id); static DEVICE_ATTR_RO(phy_id);
...@@ -537,7 +537,7 @@ phy_interface_show(struct device *dev, struct device_attribute *attr, char *buf) ...@@ -537,7 +537,7 @@ phy_interface_show(struct device *dev, struct device_attribute *attr, char *buf)
else else
mode = phy_modes(phydev->interface); mode = phy_modes(phydev->interface);
return sprintf(buf, "%s\n", mode); return sysfs_emit(buf, "%s\n", mode);
} }
static DEVICE_ATTR_RO(phy_interface); static DEVICE_ATTR_RO(phy_interface);
...@@ -547,7 +547,7 @@ phy_has_fixups_show(struct device *dev, struct device_attribute *attr, ...@@ -547,7 +547,7 @@ phy_has_fixups_show(struct device *dev, struct device_attribute *attr,
{ {
struct phy_device *phydev = to_phy_device(dev); struct phy_device *phydev = to_phy_device(dev);
return sprintf(buf, "%d\n", phydev->has_fixups); return sysfs_emit(buf, "%d\n", phydev->has_fixups);
} }
static DEVICE_ATTR_RO(phy_has_fixups); static DEVICE_ATTR_RO(phy_has_fixups);
...@@ -557,7 +557,7 @@ static ssize_t phy_dev_flags_show(struct device *dev, ...@@ -557,7 +557,7 @@ static ssize_t phy_dev_flags_show(struct device *dev,
{ {
struct phy_device *phydev = to_phy_device(dev); struct phy_device *phydev = to_phy_device(dev);
return sprintf(buf, "0x%08x\n", phydev->dev_flags); return sysfs_emit(buf, "0x%08x\n", phydev->dev_flags);
} }
static DEVICE_ATTR_RO(phy_dev_flags); static DEVICE_ATTR_RO(phy_dev_flags);
...@@ -1312,7 +1312,7 @@ phy_standalone_show(struct device *dev, struct device_attribute *attr, ...@@ -1312,7 +1312,7 @@ phy_standalone_show(struct device *dev, struct device_attribute *attr,
{ {
struct phy_device *phydev = to_phy_device(dev); struct phy_device *phydev = to_phy_device(dev);
return sprintf(buf, "%d\n", !phydev->attached_dev); return sysfs_emit(buf, "%d\n", !phydev->attached_dev);
} }
static DEVICE_ATTR_RO(phy_standalone); static DEVICE_ATTR_RO(phy_standalone);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment