Commit b558ba2f authored by Emilio G. Cota's avatar Emilio G. Cota Committed by Greg Kroah-Hartman

staging: vme: tsi148: use list_for_each_safe when deleting resources in .remove

This fixes an oops when removing the module.
Signed-off-by: default avatarEmilio G. Cota <cota@braap.org>
Acked-by: default avatarMartyn Welch <martyn.welch@ge.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent db6d8fc5
...@@ -2531,6 +2531,7 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id) ...@@ -2531,6 +2531,7 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
static void tsi148_remove(struct pci_dev *pdev) static void tsi148_remove(struct pci_dev *pdev)
{ {
struct list_head *pos = NULL; struct list_head *pos = NULL;
struct list_head *tmplist;
struct vme_master_resource *master_image; struct vme_master_resource *master_image;
struct vme_slave_resource *slave_image; struct vme_slave_resource *slave_image;
struct vme_dma_resource *dma_ctrlr; struct vme_dma_resource *dma_ctrlr;
...@@ -2589,21 +2590,21 @@ static void tsi148_remove(struct pci_dev *pdev) ...@@ -2589,21 +2590,21 @@ static void tsi148_remove(struct pci_dev *pdev)
tsi148_crcsr_exit(tsi148_bridge, pdev); tsi148_crcsr_exit(tsi148_bridge, pdev);
/* resources are stored in link list */ /* resources are stored in link list */
list_for_each(pos, &tsi148_bridge->dma_resources) { list_for_each_safe(pos, tmplist, &tsi148_bridge->dma_resources) {
dma_ctrlr = list_entry(pos, struct vme_dma_resource, list); dma_ctrlr = list_entry(pos, struct vme_dma_resource, list);
list_del(pos); list_del(pos);
kfree(dma_ctrlr); kfree(dma_ctrlr);
} }
/* resources are stored in link list */ /* resources are stored in link list */
list_for_each(pos, &tsi148_bridge->slave_resources) { list_for_each_safe(pos, tmplist, &tsi148_bridge->slave_resources) {
slave_image = list_entry(pos, struct vme_slave_resource, list); slave_image = list_entry(pos, struct vme_slave_resource, list);
list_del(pos); list_del(pos);
kfree(slave_image); kfree(slave_image);
} }
/* resources are stored in link list */ /* resources are stored in link list */
list_for_each(pos, &tsi148_bridge->master_resources) { list_for_each_safe(pos, tmplist, &tsi148_bridge->master_resources) {
master_image = list_entry(pos, struct vme_master_resource, master_image = list_entry(pos, struct vme_master_resource,
list); list);
list_del(pos); list_del(pos);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment