Commit b5a603de authored by Mihaela Muraru's avatar Mihaela Muraru Committed by Greg Kroah-Hartman

staging: speakup: Use octal permissions '0444'

Fixed the following checkpatch warning:

WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal
permissions '0444'.
Signed-off-by: default avatarMihaela Muraru <mihaela.muraru21@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 88202eca
...@@ -200,7 +200,7 @@ static void do_catch_up(struct spk_synth *synth) ...@@ -200,7 +200,7 @@ static void do_catch_up(struct spk_synth *synth)
} }
module_param_named(ser, synth_apollo.ser, int, 0444); module_param_named(ser, synth_apollo.ser, int, 0444);
module_param_named(dev, synth_apollo.dev_name, charp, S_IRUGO); module_param_named(dev, synth_apollo.dev_name, charp, 0444);
module_param_named(start, synth_apollo.startup, short, 0444); module_param_named(start, synth_apollo.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."); MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
......
...@@ -163,7 +163,7 @@ static int synth_probe(struct spk_synth *synth) ...@@ -163,7 +163,7 @@ static int synth_probe(struct spk_synth *synth)
} }
module_param_named(ser, synth_audptr.ser, int, 0444); module_param_named(ser, synth_audptr.ser, int, 0444);
module_param_named(dev, synth_audptr.dev_name, charp, S_IRUGO); module_param_named(dev, synth_audptr.dev_name, charp, 0444);
module_param_named(start, synth_audptr.startup, short, 0444); module_param_named(start, synth_audptr.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."); MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
......
...@@ -120,7 +120,7 @@ static struct spk_synth synth_bns = { ...@@ -120,7 +120,7 @@ static struct spk_synth synth_bns = {
}; };
module_param_named(ser, synth_bns.ser, int, 0444); module_param_named(ser, synth_bns.ser, int, 0444);
module_param_named(dev, synth_bns.dev_name, charp, S_IRUGO); module_param_named(dev, synth_bns.dev_name, charp, 0444);
module_param_named(start, synth_bns.startup, short, 0444); module_param_named(start, synth_bns.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."); MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
......
...@@ -227,7 +227,7 @@ static void synth_flush(struct spk_synth *synth) ...@@ -227,7 +227,7 @@ static void synth_flush(struct spk_synth *synth)
} }
module_param_named(ser, synth_decext.ser, int, 0444); module_param_named(ser, synth_decext.ser, int, 0444);
module_param_named(dev, synth_decext.dev_name, charp, S_IRUGO); module_param_named(dev, synth_decext.dev_name, charp, 0444);
module_param_named(start, synth_decext.startup, short, 0444); module_param_named(start, synth_decext.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."); MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
......
...@@ -299,7 +299,7 @@ static void synth_flush(struct spk_synth *synth) ...@@ -299,7 +299,7 @@ static void synth_flush(struct spk_synth *synth)
} }
module_param_named(ser, synth_dectlk.ser, int, 0444); module_param_named(ser, synth_dectlk.ser, int, 0444);
module_param_named(dev, synth_dectlk.dev_name, charp, S_IRUGO); module_param_named(dev, synth_dectlk.dev_name, charp, 0444);
module_param_named(start, synth_dectlk.startup, short, 0444); module_param_named(start, synth_dectlk.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."); MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
......
...@@ -122,7 +122,7 @@ static struct spk_synth synth_dummy = { ...@@ -122,7 +122,7 @@ static struct spk_synth synth_dummy = {
}; };
module_param_named(ser, synth_dummy.ser, int, 0444); module_param_named(ser, synth_dummy.ser, int, 0444);
module_param_named(dev, synth_dummy.dev_name, charp, S_IRUGO); module_param_named(dev, synth_dummy.dev_name, charp, 0444);
module_param_named(start, synth_dummy.startup, short, 0444); module_param_named(start, synth_dummy.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."); MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
......
...@@ -167,7 +167,7 @@ static int synth_probe(struct spk_synth *synth) ...@@ -167,7 +167,7 @@ static int synth_probe(struct spk_synth *synth)
} }
module_param_named(ser, synth_ltlk.ser, int, 0444); module_param_named(ser, synth_ltlk.ser, int, 0444);
module_param_named(dev, synth_ltlk.dev_name, charp, S_IRUGO); module_param_named(dev, synth_ltlk.dev_name, charp, 0444);
module_param_named(start, synth_ltlk.startup, short, 0444); module_param_named(start, synth_ltlk.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."); MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
......
...@@ -131,7 +131,7 @@ static void synth_flush(struct spk_synth *synth) ...@@ -131,7 +131,7 @@ static void synth_flush(struct spk_synth *synth)
} }
module_param_named(ser, synth_spkout.ser, int, 0444); module_param_named(ser, synth_spkout.ser, int, 0444);
module_param_named(dev, synth_spkout.dev_name, charp, S_IRUGO); module_param_named(dev, synth_spkout.dev_name, charp, 0444);
module_param_named(start, synth_spkout.startup, short, 0444); module_param_named(start, synth_spkout.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."); MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
......
...@@ -119,7 +119,7 @@ static struct spk_synth synth_txprt = { ...@@ -119,7 +119,7 @@ static struct spk_synth synth_txprt = {
}; };
module_param_named(ser, synth_txprt.ser, int, 0444); module_param_named(ser, synth_txprt.ser, int, 0444);
module_param_named(dev, synth_txprt.dev_name, charp, S_IRUGO); module_param_named(dev, synth_txprt.dev_name, charp, 0444);
module_param_named(start, synth_txprt.startup, short, 0444); module_param_named(start, synth_txprt.startup, short, 0444);
MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based)."); MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment