Commit b5bb4258 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Dennis Zhou

arm64: percpu: Initialize ret in the default case

Clang warns that if the default case is taken, ret will be
uninitialized.

./arch/arm64/include/asm/percpu.h:196:2: warning: variable 'ret' is used
uninitialized whenever switch default is taken
[-Wsometimes-uninitialized]
        default:
        ^~~~~~~
./arch/arm64/include/asm/percpu.h:200:9: note: uninitialized use occurs
here
        return ret;
               ^~~
./arch/arm64/include/asm/percpu.h:157:19: note: initialize the variable
'ret' to silence this warning
        unsigned long ret, loop;
                         ^
                          = 0

This warning appears several times while building the erofs filesystem.
While it's not strictly wrong, the BUILD_BUG will prevent this from
becoming a true problem. Initialize ret to 0 in the default case right
before the BUILD_BUG to silence all of these warnings.
Reported-by: default avatarPrasad Sodagudi <psodagud@codeaurora.org>
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarDennis Zhou <dennis@kernel.org>
parent 0b59c25f
...@@ -96,6 +96,7 @@ static inline unsigned long __percpu_##op(void *ptr, \ ...@@ -96,6 +96,7 @@ static inline unsigned long __percpu_##op(void *ptr, \
: [val] "Ir" (val)); \ : [val] "Ir" (val)); \
break; \ break; \
default: \ default: \
ret = 0; \
BUILD_BUG(); \ BUILD_BUG(); \
} \ } \
\ \
...@@ -125,6 +126,7 @@ static inline unsigned long __percpu_read(void *ptr, int size) ...@@ -125,6 +126,7 @@ static inline unsigned long __percpu_read(void *ptr, int size)
ret = READ_ONCE(*(u64 *)ptr); ret = READ_ONCE(*(u64 *)ptr);
break; break;
default: default:
ret = 0;
BUILD_BUG(); BUILD_BUG();
} }
...@@ -194,6 +196,7 @@ static inline unsigned long __percpu_xchg(void *ptr, unsigned long val, ...@@ -194,6 +196,7 @@ static inline unsigned long __percpu_xchg(void *ptr, unsigned long val,
: [val] "r" (val)); : [val] "r" (val));
break; break;
default: default:
ret = 0;
BUILD_BUG(); BUILD_BUG();
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment