Commit b6a71bfa authored by Ben Dooks's avatar Ben Dooks Committed by David S. Miller

KS8851: Fix ks8851_set_rx_mode() for IFF_MULTICAST

In ks8851_set_rx_mode() the case handling IFF_MULTICAST was also setting
the RXCR1_AE bit by accident. This meant that all unicast frames where
being accepted by the device. Remove RXCR1_AE from this case.

Note, RXCR1_AE was also masking a problem with setting the MAC address
properly, so needs to be applied after fixing the MAC write order.

Fixes a bug reported by Doong, Ping of Micrel. This version of the
patch avoids setting RXCR1_ME for all cases.
Signed-off-by: default avatarBen Dooks <ben@simtec.co.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 160d0fad
...@@ -980,7 +980,7 @@ static void ks8851_set_rx_mode(struct net_device *dev) ...@@ -980,7 +980,7 @@ static void ks8851_set_rx_mode(struct net_device *dev)
mcptr = mcptr->next; mcptr = mcptr->next;
} }
rxctrl.rxcr1 = RXCR1_RXME | RXCR1_RXAE | RXCR1_RXPAFMA; rxctrl.rxcr1 = RXCR1_RXME | RXCR1_RXPAFMA;
} else { } else {
/* just accept broadcast / unicast */ /* just accept broadcast / unicast */
rxctrl.rxcr1 = RXCR1_RXPAFMA; rxctrl.rxcr1 = RXCR1_RXPAFMA;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment