Commit b6ac59d3 authored by Qinglang Miao's avatar Qinglang Miao Committed by Michael Ellerman

powerpc: use for_each_child_of_node() macro

Use for_each_child_of_node() macro instead of open coding it.
Signed-off-by: default avatarQinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200728022807.87815-1-miaoqinglang@huawei.com
parent f2af2010
...@@ -56,8 +56,7 @@ static int __init pasemi_register_i2c_devices(void) ...@@ -56,8 +56,7 @@ static int __init pasemi_register_i2c_devices(void)
if (!adap_node) if (!adap_node)
continue; continue;
node = NULL; for_each_child_of_node(adap_node, node) {
while ((node = of_get_next_child(adap_node, node))) {
struct i2c_board_info info = {}; struct i2c_board_info info = {};
const u32 *addr; const u32 *addr;
int len; int len;
......
...@@ -629,8 +629,7 @@ static void __init kw_i2c_probe(void) ...@@ -629,8 +629,7 @@ static void __init kw_i2c_probe(void)
for (i = 0; i < chans; i++) for (i = 0; i < chans; i++)
kw_i2c_add(host, np, np, i); kw_i2c_add(host, np, np, i);
} else { } else {
for (child = NULL; for_each_child_of_node(np, child) {
(child = of_get_next_child(np, child)) != NULL;) {
const u32 *reg = of_get_property(child, const u32 *reg = of_get_property(child,
"reg", NULL); "reg", NULL);
if (reg == NULL) if (reg == NULL)
...@@ -1193,8 +1192,7 @@ static void pmac_i2c_devscan(void (*callback)(struct device_node *dev, ...@@ -1193,8 +1192,7 @@ static void pmac_i2c_devscan(void (*callback)(struct device_node *dev,
* platform function instance * platform function instance
*/ */
list_for_each_entry(bus, &pmac_i2c_busses, link) { list_for_each_entry(bus, &pmac_i2c_busses, link) {
for (np = NULL; for_each_child_of_node(bus->busnode, np) {
(np = of_get_next_child(bus->busnode, np)) != NULL;) {
struct whitelist_ent *p; struct whitelist_ent *p;
/* If multibus, check if device is on that bus */ /* If multibus, check if device is on that bus */
if (bus->flags & pmac_i2c_multibus) if (bus->flags & pmac_i2c_multibus)
......
...@@ -114,7 +114,7 @@ static void macio_gpio_init_one(struct macio_chip *macio) ...@@ -114,7 +114,7 @@ static void macio_gpio_init_one(struct macio_chip *macio)
* Ok, got one, we dont need anything special to track them down, so * Ok, got one, we dont need anything special to track them down, so
* we just create them all * we just create them all
*/ */
for (gp = NULL; (gp = of_get_next_child(gparent, gp)) != NULL;) { for_each_child_of_node(gparent, gp) {
const u32 *reg = of_get_property(gp, "reg", NULL); const u32 *reg = of_get_property(gp, "reg", NULL);
unsigned long offset; unsigned long offset;
if (reg == NULL) if (reg == NULL)
...@@ -133,7 +133,7 @@ static void macio_gpio_init_one(struct macio_chip *macio) ...@@ -133,7 +133,7 @@ static void macio_gpio_init_one(struct macio_chip *macio)
macio->of_node); macio->of_node);
/* And now we run all the init ones */ /* And now we run all the init ones */
for (gp = NULL; (gp = of_get_next_child(gparent, gp)) != NULL;) for_each_child_of_node(gparent, gp)
pmf_do_functions(gp, NULL, 0, PMF_FLAGS_ON_INIT, NULL); pmf_do_functions(gp, NULL, 0, PMF_FLAGS_ON_INIT, NULL);
/* Note: We do not at this point implement the "at sleep" or "at wake" /* Note: We do not at this point implement the "at sleep" or "at wake"
......
...@@ -80,7 +80,7 @@ void udbg_scc_init(int force_scc) ...@@ -80,7 +80,7 @@ void udbg_scc_init(int force_scc)
path = of_get_property(of_chosen, "linux,stdout-path", NULL); path = of_get_property(of_chosen, "linux,stdout-path", NULL);
if (path != NULL) if (path != NULL)
stdout = of_find_node_by_path(path); stdout = of_find_node_by_path(path);
for (ch = NULL; (ch = of_get_next_child(escc, ch)) != NULL;) { for_each_child_of_node(escc, ch) {
if (ch == stdout) if (ch == stdout)
ch_def = of_node_get(ch); ch_def = of_node_get(ch);
if (of_node_name_eq(ch, "ch-a")) if (of_node_name_eq(ch, "ch-a"))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment