Commit b761dcf1 authored by Xiao Ni's avatar Xiao Ni Committed by Song Liu

It's wrong to add len to sector_nr in raid10 reshape twice

In reshape_request it already adds len to sector_nr already. It's wrong to add len to
sector_nr again after adding pages to bio. If there is bad block it can't copy one chunk
at a time, it needs to goto read_more. Now the sector_nr is wrong. It can cause data
corruption.

Cc: stable@vger.kernel.org # v3.16+
Signed-off-by: default avatarXiao Ni <xni@redhat.com>
Signed-off-by: default avatarSong Liu <songliubraving@fb.com>
parent a596d086
...@@ -4670,7 +4670,6 @@ static sector_t reshape_request(struct mddev *mddev, sector_t sector_nr, ...@@ -4670,7 +4670,6 @@ static sector_t reshape_request(struct mddev *mddev, sector_t sector_nr,
atomic_inc(&r10_bio->remaining); atomic_inc(&r10_bio->remaining);
read_bio->bi_next = NULL; read_bio->bi_next = NULL;
generic_make_request(read_bio); generic_make_request(read_bio);
sector_nr += nr_sectors;
sectors_done += nr_sectors; sectors_done += nr_sectors;
if (sector_nr <= last) if (sector_nr <= last)
goto read_more; goto read_more;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment