Commit b79a980f authored by Lee Jones's avatar Lee Jones

mfd: arizona-core: msleep() is unreliable for anything <20ms use usleep_range() instead

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+               msleep(1);

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+                       msleep(5);

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+               msleep(1);

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
+               msleep(1);

total: 0 errors, 4 warnings, 1407 lines checked

Cc: patches@opensource.wolfsonmicro.com
Acked-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 3103d44e
...@@ -238,7 +238,7 @@ static int arizona_poll_reg(struct arizona *arizona, ...@@ -238,7 +238,7 @@ static int arizona_poll_reg(struct arizona *arizona,
if ((val & mask) == target) if ((val & mask) == target)
return 0; return 0;
msleep(1); usleep_range(1000, 5000);
} }
dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val); dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val);
...@@ -279,14 +279,14 @@ static void arizona_disable_reset(struct arizona *arizona) ...@@ -279,14 +279,14 @@ static void arizona_disable_reset(struct arizona *arizona)
case WM5110: case WM5110:
case WM8280: case WM8280:
/* Meet requirements for minimum reset duration */ /* Meet requirements for minimum reset duration */
msleep(5); usleep_range(5000, 10000);
break; break;
default: default:
break; break;
} }
gpio_set_value_cansleep(arizona->pdata.reset, 1); gpio_set_value_cansleep(arizona->pdata.reset, 1);
msleep(1); usleep_range(1000, 5000);
} }
} }
...@@ -1132,7 +1132,7 @@ int arizona_dev_init(struct arizona *arizona) ...@@ -1132,7 +1132,7 @@ int arizona_dev_init(struct arizona *arizona)
goto err_reset; goto err_reset;
} }
msleep(1); usleep_range(1000, 5000);
} }
/* Ensure device startup is complete */ /* Ensure device startup is complete */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment