Commit b8031342 authored by Sarah Sharp's avatar Sarah Sharp

xhci: Fix missing break in xhci_evaluate_context_result.

Coverity complains that xhci_evaluate_context_result() is missing a
break statement after the COMP_EBADSLT switch case.  It's not a big
deal, since we wanted to return the same error code as the case
statement below it does.  The end result would be one that a Slot
Disabled error completion code would also print the warning message
associated with a Context State error code.  No other bad behavior would
result.

It's not worth backporting to stable kernels, since it only fixes an
issue with too much debugging.
Signed-off-by: default avatarSarah Sharp <sarah.a.sharp@linux.intel.com>
parent 43a09f7f
...@@ -1817,6 +1817,8 @@ static int xhci_evaluate_context_result(struct xhci_hcd *xhci, ...@@ -1817,6 +1817,8 @@ static int xhci_evaluate_context_result(struct xhci_hcd *xhci,
case COMP_EBADSLT: case COMP_EBADSLT:
dev_warn(&udev->dev, "WARN: slot not enabled for" dev_warn(&udev->dev, "WARN: slot not enabled for"
"evaluate context command.\n"); "evaluate context command.\n");
ret = -EINVAL;
break;
case COMP_CTX_STATE: case COMP_CTX_STATE:
dev_warn(&udev->dev, "WARN: invalid context state for " dev_warn(&udev->dev, "WARN: invalid context state for "
"evaluate context command.\n"); "evaluate context command.\n");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment