Commit b815555d authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

Staging: lustre: ptlrpc: signedness bug in high_priority_ratio_store()

We want to store a non-negative int here.  The original code had a check
for unsigned long less than zero which is a mistake but also casting
from a positive long to an int can result in a negative number.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 02b31079
...@@ -1035,9 +1035,9 @@ static ssize_t high_priority_ratio_store(struct kobject *kobj, ...@@ -1035,9 +1035,9 @@ static ssize_t high_priority_ratio_store(struct kobject *kobj,
struct ptlrpc_service *svc = container_of(kobj, struct ptlrpc_service, struct ptlrpc_service *svc = container_of(kobj, struct ptlrpc_service,
srv_kobj); srv_kobj);
int rc; int rc;
unsigned long val; int val;
rc = kstrtoul(buffer, 10, &val); rc = kstrtoint(buffer, 10, &val);
if (rc < 0) if (rc < 0)
return rc; return rc;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment