Commit b87c0adf authored by Chuck Lever's avatar Chuck Lever Committed by Linus Torvalds

[PATCH] NFS: remove unused check in nfs4_open_revalidate

Coverity spotted a superfluous error check in nfs4_open_revalidate().  Remove
it.

Coverity: #cid 847

Test plan:
Code inspection; another pass through Coverity.
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 85233a7a
...@@ -1314,11 +1314,9 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st ...@@ -1314,11 +1314,9 @@ nfs4_open_revalidate(struct inode *dir, struct dentry *dentry, int openflags, st
case -EROFS: case -EROFS:
lookup_instantiate_filp(nd, (struct dentry *)state, NULL); lookup_instantiate_filp(nd, (struct dentry *)state, NULL);
return 1; return 1;
case -ENOENT: default:
if (dentry->d_inode == NULL) goto out_drop;
return 1;
} }
goto out_drop;
} }
if (state->inode == dentry->d_inode) { if (state->inode == dentry->d_inode) {
nfs4_intent_set_file(nd, dentry, state); nfs4_intent_set_file(nd, dentry, state);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment