Commit b8b615b5 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Hans Verkuil

media: vidtv_bridge: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
parent f3675a01
...@@ -528,7 +528,7 @@ static int vidtv_bridge_probe(struct platform_device *pdev) ...@@ -528,7 +528,7 @@ static int vidtv_bridge_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int vidtv_bridge_remove(struct platform_device *pdev) static void vidtv_bridge_remove(struct platform_device *pdev)
{ {
struct vidtv_dvb *dvb; struct vidtv_dvb *dvb;
u32 i; u32 i;
...@@ -552,8 +552,6 @@ static int vidtv_bridge_remove(struct platform_device *pdev) ...@@ -552,8 +552,6 @@ static int vidtv_bridge_remove(struct platform_device *pdev)
dvb_dmx_release(&dvb->demux); dvb_dmx_release(&dvb->demux);
dvb_unregister_adapter(&dvb->adapter); dvb_unregister_adapter(&dvb->adapter);
dev_info(&pdev->dev, "Successfully removed vidtv\n"); dev_info(&pdev->dev, "Successfully removed vidtv\n");
return 0;
} }
static void vidtv_bridge_dev_release(struct device *dev) static void vidtv_bridge_dev_release(struct device *dev)
...@@ -574,7 +572,7 @@ static struct platform_driver vidtv_bridge_driver = { ...@@ -574,7 +572,7 @@ static struct platform_driver vidtv_bridge_driver = {
.name = VIDTV_PDEV_NAME, .name = VIDTV_PDEV_NAME,
}, },
.probe = vidtv_bridge_probe, .probe = vidtv_bridge_probe,
.remove = vidtv_bridge_remove, .remove_new = vidtv_bridge_remove,
}; };
static void __exit vidtv_bridge_exit(void) static void __exit vidtv_bridge_exit(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment