Commit b8d9ee24 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

usb: phy: ab8500: silence some uninitialized variable warnings

Smatch complains that "reg" can be uninitialized if the
abx500_get_register_interruptible() call fails.  It's an interruptable
function, so we should check if the user presses CTRL-C.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6494a9ad
...@@ -505,15 +505,19 @@ static int abx500_usb_link_status_update(struct ab8500_usb *ab) ...@@ -505,15 +505,19 @@ static int abx500_usb_link_status_update(struct ab8500_usb *ab)
if (is_ab8500(ab->ab8500)) { if (is_ab8500(ab->ab8500)) {
enum ab8500_usb_link_status lsts; enum ab8500_usb_link_status lsts;
abx500_get_register_interruptible(ab->dev, ret = abx500_get_register_interruptible(ab->dev,
AB8500_USB, AB8500_USB_LINE_STAT_REG, &reg); AB8500_USB, AB8500_USB_LINE_STAT_REG, &reg);
if (ret < 0)
return ret;
lsts = (reg >> 3) & 0x0F; lsts = (reg >> 3) & 0x0F;
ret = ab8500_usb_link_status_update(ab, lsts); ret = ab8500_usb_link_status_update(ab, lsts);
} else if (is_ab8505(ab->ab8500)) { } else if (is_ab8505(ab->ab8500)) {
enum ab8505_usb_link_status lsts; enum ab8505_usb_link_status lsts;
abx500_get_register_interruptible(ab->dev, ret = abx500_get_register_interruptible(ab->dev,
AB8500_USB, AB8505_USB_LINE_STAT_REG, &reg); AB8500_USB, AB8505_USB_LINE_STAT_REG, &reg);
if (ret < 0)
return ret;
lsts = (reg >> 3) & 0x1F; lsts = (reg >> 3) & 0x1F;
ret = ab8505_usb_link_status_update(ab, lsts); ret = ab8505_usb_link_status_update(ab, lsts);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment