Commit b8e3468d authored by Joe Thornber's avatar Joe Thornber Committed by Luis Henriques

dm thin metadata: fix bug when taking a metadata snapshot

commit 49e99fc7 upstream.

When you take a metadata snapshot the btree roots for the mapping and
details tree need to have their reference counts incremented so they
persist for the lifetime of the metadata snap.

The roots being incremented were those currently written in the
superblock, which could possibly be out of date if concurrent IO is
triggering new mappings, breaking of sharing, etc.

Fix this by performing a commit with the metadata lock held while taking
a metadata snapshot.
Signed-off-by: default avatarJoe Thornber <ejt@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent b7caa158
...@@ -1204,6 +1204,12 @@ static int __reserve_metadata_snap(struct dm_pool_metadata *pmd) ...@@ -1204,6 +1204,12 @@ static int __reserve_metadata_snap(struct dm_pool_metadata *pmd)
struct dm_block *copy, *sblock; struct dm_block *copy, *sblock;
dm_block_t held_root; dm_block_t held_root;
/*
* We commit to ensure the btree roots which we increment in a
* moment are up to date.
*/
__commit_transaction(pmd);
/* /*
* Copy the superblock. * Copy the superblock.
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment