Commit b906cfa3 authored by Sebastien Dugue's avatar Sebastien Dugue Committed by Paul Mackerras

powerpc/pseries: Fix cpu hotplug

Currently, pseries_cpu_die() calls msleep() while polling RTAS for
the status of the dying cpu.

However, if the cpu that is going down also happens to be the one
doing the tick then we're hosed as the tick_do_timer_cpu 'baton' is
only passed later on in tick_shutdown() when _cpu_down() does the
CPU_DEAD notification.  Therefore jiffies won't be updated anymore.

This replaces that msleep() with a cpu_relax() to make sure we're not
going to schedule at that point.

With this patch my test box survives a 100k iterations hotplug stress
test on _all_ cpus, whereas without it, it quickly dies after ~50
iterations.
Signed-off-by: default avatarSebastien Dugue <sebastien.dugue@bull.net>
Cc: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: default avatarPaul Mackerras <paulus@samba.org>
parent fad7b9b5
...@@ -116,7 +116,7 @@ static void pseries_cpu_die(unsigned int cpu) ...@@ -116,7 +116,7 @@ static void pseries_cpu_die(unsigned int cpu)
cpu_status = query_cpu_stopped(pcpu); cpu_status = query_cpu_stopped(pcpu);
if (cpu_status == 0 || cpu_status == -1) if (cpu_status == 0 || cpu_status == -1)
break; break;
msleep(200); cpu_relax();
} }
if (cpu_status != 0) { if (cpu_status != 0) {
printk("Querying DEAD? cpu %i (%i) shows %i\n", printk("Querying DEAD? cpu %i (%i) shows %i\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment