Commit b9111328 authored by Maxime Ripard's avatar Maxime Ripard Committed by David S. Miller

net: allwinner: emac: Add missing free_irq

If the mdio probe function fails in emac_open, the interrupt we just requested
isn't freed. If emac_open is called again, for example because we try to set up
the interface again, the kernel will oops because the interrupt wasn't properly
released.
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@free-electrons.com>
Cc: <stable@vger.kernel.org> # 3.11+
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 40c9f8ab
...@@ -736,6 +736,7 @@ static int emac_open(struct net_device *dev) ...@@ -736,6 +736,7 @@ static int emac_open(struct net_device *dev)
ret = emac_mdio_probe(dev); ret = emac_mdio_probe(dev);
if (ret < 0) { if (ret < 0) {
free_irq(dev->irq, dev);
netdev_err(dev, "cannot probe MDIO bus\n"); netdev_err(dev, "cannot probe MDIO bus\n");
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment