Commit b9302fa7 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Mauro Carvalho Chehab

media: tuners: fix error return code of hybrid_tuner_request_state()

When kzalloc() fails and state is NULL, no error return code is
assigned.
To fix this bug, __ret is assigned with -ENOMEM in this case.
Reported-by: default avatarTOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent f3d384e3
...@@ -133,8 +133,10 @@ static inline int tuner_i2c_xfer_send_recv(struct tuner_i2c_props *props, ...@@ -133,8 +133,10 @@ static inline int tuner_i2c_xfer_send_recv(struct tuner_i2c_props *props,
} \ } \
if (0 == __ret) { \ if (0 == __ret) { \
state = kzalloc(sizeof(type), GFP_KERNEL); \ state = kzalloc(sizeof(type), GFP_KERNEL); \
if (NULL == state) \ if (!state) { \
__ret = -ENOMEM; \
goto __fail; \ goto __fail; \
} \
state->i2c_props.addr = i2caddr; \ state->i2c_props.addr = i2caddr; \
state->i2c_props.adap = i2cadap; \ state->i2c_props.adap = i2cadap; \
state->i2c_props.name = devname; \ state->i2c_props.name = devname; \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment