Commit b9306a79 authored by Yang Shi's avatar Yang Shi Committed by Linus Torvalds

mm: filemap: clear idle flag for writes

Since commit bbddabe2 ("mm: filemap: only do access activations on
reads"), mark_page_accessed() is called for reads only.  But the idle flag
is cleared by mark_page_accessed() so the idle flag won't get cleared if
the page is write accessed only.

Basically idle page tracking is used to estimate workingset size of
workload, noticeable size of workingset might be missed if the idle flag
is not maintained correctly.

It seems good enough to just clear idle flag for write operations.

Fixes: bbddabe2 ("mm: filemap: only do access activations on reads")
Reported-by: default avatarGang Deng <gavin.dg@linux.alibaba.com>
Signed-off-by: default avatarYang Shi <yang.shi@linux.alibaba.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarShakeel Butt <shakeelb@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Rik van Riel <riel@surriel.com>
Link: http://lkml.kernel.org/r/1593020612-13051-1-git-send-email-yang.shi@linux.alibaba.comSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6dc5ea16
...@@ -41,6 +41,7 @@ ...@@ -41,6 +41,7 @@
#include <linux/delayacct.h> #include <linux/delayacct.h>
#include <linux/psi.h> #include <linux/psi.h>
#include <linux/ramfs.h> #include <linux/ramfs.h>
#include <linux/page_idle.h>
#include "internal.h" #include "internal.h"
#define CREATE_TRACE_POINTS #define CREATE_TRACE_POINTS
...@@ -1689,6 +1690,11 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index, ...@@ -1689,6 +1690,11 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index,
if (fgp_flags & FGP_ACCESSED) if (fgp_flags & FGP_ACCESSED)
mark_page_accessed(page); mark_page_accessed(page);
else if (fgp_flags & FGP_WRITE) {
/* Clear idle flag for buffer write */
if (page_is_idle(page))
clear_page_idle(page);
}
no_page: no_page:
if (!page && (fgp_flags & FGP_CREAT)) { if (!page && (fgp_flags & FGP_CREAT)) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment