Commit baacf9c5 authored by Bruno Prémont's avatar Bruno Prémont Committed by Jiri Kosina

HID: picoLCD: satify some checkpatch warnings

WARNING: static const char * array should probably be static const char * const
+static const char *error_codes[] = {

WARNING: min() should probably be min_t(size_t, 20, s)
+       raw_data[2] = min((size_t)20, s);

Note: the second min_t suggestion cannot be followed because GCC is not
smart enough to track constants through it and make
copy_from_user_overflow() check happy.

WARNING: min() should probably be min_t(u8, 20, raw_data[2])
+       if (copy_from_user(raw_data+3, u, min((u8)20, raw_data[2])))
                return -EFAULT;
Signed-off-by: default avatarBruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent b07072e6
...@@ -135,7 +135,7 @@ static ssize_t picolcd_debug_eeprom_write(struct file *f, const char __user *u, ...@@ -135,7 +135,7 @@ static ssize_t picolcd_debug_eeprom_write(struct file *f, const char __user *u,
memset(raw_data, 0, sizeof(raw_data)); memset(raw_data, 0, sizeof(raw_data));
raw_data[0] = *off & 0xff; raw_data[0] = *off & 0xff;
raw_data[1] = (*off >> 8) & 0xff; raw_data[1] = (*off >> 8) & 0xff;
raw_data[2] = min((size_t)20, s); raw_data[2] = min_t(size_t, 20, s);
if (*off + raw_data[2] > 0xff) if (*off + raw_data[2] > 0xff)
raw_data[2] = 0x100 - *off; raw_data[2] = 0x100 - *off;
...@@ -370,7 +370,7 @@ static const struct file_operations picolcd_debug_flash_fops = { ...@@ -370,7 +370,7 @@ static const struct file_operations picolcd_debug_flash_fops = {
/* /*
* Helper code for HID report level dumping/debugging * Helper code for HID report level dumping/debugging
*/ */
static const char *error_codes[] = { static const char * const error_codes[] = {
"success", "parameter missing", "data_missing", "block readonly", "success", "parameter missing", "data_missing", "block readonly",
"block not erasable", "block too big", "section overflow", "block not erasable", "block too big", "section overflow",
"invalid command length", "invalid data length", "invalid command length", "invalid data length",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment