Commit bba14b32 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Gregory CLEMENT

ARM: orion/gpio: Get rid of unused first parameter in orion_gpio_init()

The OF node pointer is always NULL, get rid of unused parameter in
orion_gpio_init(). As a side effect it will allow to switch GPIO
library to the fwnode API, as well as in case of resurrecting it here
it should be fwnode_handle anyways.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarGregory CLEMENT <gregory.clement@bootlin.com>
parent e783362e
...@@ -73,12 +73,12 @@ void __init dove_init_irq(void) ...@@ -73,12 +73,12 @@ void __init dove_init_irq(void)
/* /*
* Initialize gpiolib for GPIOs 0-71. * Initialize gpiolib for GPIOs 0-71.
*/ */
orion_gpio_init(NULL, 0, 32, DOVE_GPIO_LO_VIRT_BASE, 0, orion_gpio_init(0, 32, DOVE_GPIO_LO_VIRT_BASE, 0,
IRQ_DOVE_GPIO_START, gpio0_irqs); IRQ_DOVE_GPIO_START, gpio0_irqs);
orion_gpio_init(NULL, 32, 32, DOVE_GPIO_HI_VIRT_BASE, 0, orion_gpio_init(32, 32, DOVE_GPIO_HI_VIRT_BASE, 0,
IRQ_DOVE_GPIO_START + 32, gpio1_irqs); IRQ_DOVE_GPIO_START + 32, gpio1_irqs);
orion_gpio_init(NULL, 64, 8, DOVE_GPIO2_VIRT_BASE, 0, orion_gpio_init(64, 8, DOVE_GPIO2_VIRT_BASE, 0,
IRQ_DOVE_GPIO_START + 64, gpio2_irqs); IRQ_DOVE_GPIO_START + 64, gpio2_irqs);
} }
...@@ -67,7 +67,6 @@ void __init mv78xx0_init_irq(void) ...@@ -67,7 +67,6 @@ void __init mv78xx0_init_irq(void)
* registers for core #1 are at an offset of 0x18 from those of * registers for core #1 are at an offset of 0x18 from those of
* core #0.) * core #0.)
*/ */
orion_gpio_init(NULL, 0, 32, GPIO_VIRT_BASE, orion_gpio_init(0, 32, GPIO_VIRT_BASE, mv78xx0_core_index() ? 0x18 : 0,
mv78xx0_core_index() ? 0x18 : 0,
IRQ_MV78XX0_GPIO_START, gpio0_irqs); IRQ_MV78XX0_GPIO_START, gpio0_irqs);
} }
...@@ -49,6 +49,6 @@ void __init orion5x_init_irq(void) ...@@ -49,6 +49,6 @@ void __init orion5x_init_irq(void)
/* /*
* Initialize gpiolib for GPIOs 0-31. * Initialize gpiolib for GPIOs 0-31.
*/ */
orion_gpio_init(NULL, 0, 32, GPIO_VIRT_BASE, 0, orion_gpio_init(0, 32, GPIO_VIRT_BASE, 0,
IRQ_ORION5X_GPIO_START, gpio0_irqs); IRQ_ORION5X_GPIO_START, gpio0_irqs);
} }
...@@ -516,8 +516,7 @@ static void orion_gpio_mask_irq(struct irq_data *d) ...@@ -516,8 +516,7 @@ static void orion_gpio_mask_irq(struct irq_data *d)
irq_gc_unlock(gc); irq_gc_unlock(gc);
} }
void __init orion_gpio_init(struct device_node *np, void __init orion_gpio_init(int gpio_base, int ngpio,
int gpio_base, int ngpio,
void __iomem *base, int mask_offset, void __iomem *base, int mask_offset,
int secondary_irq_base, int secondary_irq_base,
int irqs[4]) int irqs[4])
...@@ -545,9 +544,6 @@ void __init orion_gpio_init(struct device_node *np, ...@@ -545,9 +544,6 @@ void __init orion_gpio_init(struct device_node *np,
ochip->chip.base = gpio_base; ochip->chip.base = gpio_base;
ochip->chip.ngpio = ngpio; ochip->chip.ngpio = ngpio;
ochip->chip.can_sleep = 0; ochip->chip.can_sleep = 0;
#ifdef CONFIG_OF
ochip->chip.of_node = np;
#endif
ochip->chip.dbg_show = orion_gpio_dbg_show; ochip->chip.dbg_show = orion_gpio_dbg_show;
spin_lock_init(&ochip->lock); spin_lock_init(&ochip->lock);
...@@ -605,7 +601,7 @@ void __init orion_gpio_init(struct device_node *np, ...@@ -605,7 +601,7 @@ void __init orion_gpio_init(struct device_node *np,
IRQ_NOREQUEST, IRQ_LEVEL | IRQ_NOPROBE); IRQ_NOREQUEST, IRQ_LEVEL | IRQ_NOPROBE);
/* Setup irq domain on top of the generic chip. */ /* Setup irq domain on top of the generic chip. */
ochip->domain = irq_domain_add_legacy(np, ochip->domain = irq_domain_add_legacy(NULL,
ochip->chip.ngpio, ochip->chip.ngpio,
ochip->secondary_irq_base, ochip->secondary_irq_base,
ochip->secondary_irq_base, ochip->secondary_irq_base,
......
...@@ -30,8 +30,7 @@ int orion_gpio_led_blink_set(struct gpio_desc *desc, int state, ...@@ -30,8 +30,7 @@ int orion_gpio_led_blink_set(struct gpio_desc *desc, int state,
void orion_gpio_set_valid(unsigned pin, int mode); void orion_gpio_set_valid(unsigned pin, int mode);
/* Initialize gpiolib. */ /* Initialize gpiolib. */
void __init orion_gpio_init(struct device_node *np, void __init orion_gpio_init(int gpio_base, int ngpio,
int gpio_base, int ngpio,
void __iomem *base, int mask_offset, void __iomem *base, int mask_offset,
int secondary_irq_base, int secondary_irq_base,
int irq[4]); int irq[4]);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment