Commit bc44bd1d authored by Bart Van Assche's avatar Bart Van Assche Committed by Doug Ledford

IB/srp: Stop the scsi_eh_<n> and scsi_tmf_<n> threads if login fails

scsi_host_alloc() not only allocates memory for a SCSI host but also
creates the scsi_eh_<n> kernel thread and the scsi_tmf_<n> workqueue.
Stop these threads if login fails by calling scsi_host_put().
Reported-by: default avatarKonstantin Krotov <kkv@clodo.ru>
Fixes: fb49c8bb ("Remove an extraneous scsi_host_put() from an error path")
Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Cc: Sagi Grimberg <sagig@mellanox.com>
Cc: Sebastian Parschauer <sebastian.riemer@profitbricks.com>
Cc: <stable@vger.kernel.org> #v3.19
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 713ef24e
...@@ -2758,6 +2758,13 @@ static int srp_sdev_count(struct Scsi_Host *host) ...@@ -2758,6 +2758,13 @@ static int srp_sdev_count(struct Scsi_Host *host)
return c; return c;
} }
/*
* Return values:
* < 0 upon failure. Caller is responsible for SRP target port cleanup.
* 0 and target->state == SRP_TARGET_REMOVED if asynchronous target port
* removal has been scheduled.
* 0 and target->state != SRP_TARGET_REMOVED upon success.
*/
static int srp_add_target(struct srp_host *host, struct srp_target_port *target) static int srp_add_target(struct srp_host *host, struct srp_target_port *target)
{ {
struct srp_rport_identifiers ids; struct srp_rport_identifiers ids;
...@@ -3296,6 +3303,8 @@ static ssize_t srp_create_target(struct device *dev, ...@@ -3296,6 +3303,8 @@ static ssize_t srp_create_target(struct device *dev,
mutex_unlock(&host->add_target_mutex); mutex_unlock(&host->add_target_mutex);
scsi_host_put(target->scsi_host); scsi_host_put(target->scsi_host);
if (ret < 0)
scsi_host_put(target->scsi_host);
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment