Commit bdf29b0a authored by Dave Kleikamp's avatar Dave Kleikamp

JFS: remove racy, redundant call to block_invalidatepage

__invalidate_metapages references mp->page after after releasing the
meta_lock spinlock, without increasing the use count.  This is racy and
unnecessary since setting the META_discard flag is sufficient.
block_invalidatepage() will be called when the metapage is released.
parent 1910e4dc
...@@ -511,9 +511,6 @@ void __invalidate_metapages(struct inode *ip, s64 addr, int len) ...@@ -511,9 +511,6 @@ void __invalidate_metapages(struct inode *ip, s64 addr, int len)
if (mp) { if (mp) {
set_bit(META_discard, &mp->flag); set_bit(META_discard, &mp->flag);
spin_unlock(&meta_lock); spin_unlock(&meta_lock);
lock_page(mp->page);
block_invalidatepage(mp->page, 0);
unlock_page(mp->page);
} else { } else {
spin_unlock(&meta_lock); spin_unlock(&meta_lock);
page = find_lock_page(mapping, lblock>>l2BlocksPerPage); page = find_lock_page(mapping, lblock>>l2BlocksPerPage);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment