Commit bdfd36ef authored by Ville Syrjälä's avatar Ville Syrjälä Committed by Vincent Abriou

drm/sti: Fix sparse warnings

drm/sti/sti_mixer.c:361:6: warning: symbol 'sti_mixer_set_matrix' was not declared. Should it be static?
drm/sti/sti_gdp.c:476:5: warning: symbol 'sti_gdp_field_cb' was not declared. Should it be static?
drm/sti/sti_gdp.c:885:24: warning: symbol 'sti_gdp_plane_helpers_funcs' was not declared. Should it be static?
drm/sti/sti_cursor.c:348:24: warning: symbol 'sti_cursor_plane_helpers_funcs' was not declared. Should it be static?
drm/sti/sti_compositor.c:28:28: warning: symbol 'stih407_compositor_data' was not declared. Should it be static?
drm/sti/sti_compositor.c:49:28: warning: symbol 'stih416_compositor_data' was not declared. Should it be static?
drm/sti/sti_vtg.c:75:1: warning: symbol 'vtg_lookup' was not declared. Should it be static?
drm/sti/sti_vtg.c:476:24: warning: symbol 'sti_vtg_driver' was not declared. Should it be static?
drm/sti/sti_dvo.c:109:5: warning: symbol 'dvo_awg_generate_code' was not declared. Should it be static?
drm/sti/sti_dvo.c:602:24: warning: symbol 'sti_dvo_driver' was not declared. Should it be static?
drm/sti/sti_vtac.c:209:24: warning: symbol 'sti_vtac_driver' was not declared. Should it be static?
drm/sti/sti_tvout.c:914:24: warning: symbol 'sti_tvout_driver' was not declared. Should it be static?
drm/sti/sti_hqvdp.c:786:5: warning: symbol 'sti_hqvdp_vtg_cb' was not declared. Should it be static?
drm/sti/sti_hqvdp.c:1253:24: warning: symbol 'sti_hqvdp_plane_helpers_funcs' was not declared. Should it be static?
drm/sti/sti_hqvdp.c:1292:5: warning: symbol 'sti_hqvdp_bind' was not declared. Should it be static?
drm/sti/sti_hqvdp.c:1385:24: warning: symbol 'sti_hqvdp_driver' was not declared. Should it be static?
drm/sti/sti_drv.c:143:6: warning: symbol 'sti_drm_dbg_cleanup' was not declared. Should it be static?

Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Acked-by: default avatarVincent Abriou <vincent.abriou@st.com>
parent 7c0ca70b
...@@ -25,7 +25,7 @@ ...@@ -25,7 +25,7 @@
/* /*
* stiH407 compositor properties * stiH407 compositor properties
*/ */
struct sti_compositor_data stih407_compositor_data = { static const struct sti_compositor_data stih407_compositor_data = {
.nb_subdev = 8, .nb_subdev = 8,
.subdev_desc = { .subdev_desc = {
{STI_CURSOR_SUBDEV, (int)STI_CURSOR, 0x000}, {STI_CURSOR_SUBDEV, (int)STI_CURSOR, 0x000},
...@@ -46,7 +46,7 @@ struct sti_compositor_data stih407_compositor_data = { ...@@ -46,7 +46,7 @@ struct sti_compositor_data stih407_compositor_data = {
* Moreover, GDPx is different for Main and Aux Mixer. So this subdev map does * Moreover, GDPx is different for Main and Aux Mixer. So this subdev map does
* not fit for stiH416 if we want to enable the MIXER_AUX. * not fit for stiH416 if we want to enable the MIXER_AUX.
*/ */
struct sti_compositor_data stih416_compositor_data = { static const struct sti_compositor_data stih416_compositor_data = {
.nb_subdev = 3, .nb_subdev = 3,
.subdev_desc = { .subdev_desc = {
{STI_GPD_SUBDEV, (int)STI_GDP_0, 0x100}, {STI_GPD_SUBDEV, (int)STI_GDP_0, 0x100},
......
...@@ -345,7 +345,7 @@ static int sti_cursor_late_register(struct drm_plane *drm_plane) ...@@ -345,7 +345,7 @@ static int sti_cursor_late_register(struct drm_plane *drm_plane)
return cursor_debugfs_init(cursor, drm_plane->dev->primary); return cursor_debugfs_init(cursor, drm_plane->dev->primary);
} }
struct drm_plane_funcs sti_cursor_plane_helpers_funcs = { static const struct drm_plane_funcs sti_cursor_plane_helpers_funcs = {
.update_plane = drm_atomic_helper_update_plane, .update_plane = drm_atomic_helper_update_plane,
.disable_plane = drm_atomic_helper_disable_plane, .disable_plane = drm_atomic_helper_disable_plane,
.destroy = sti_cursor_destroy, .destroy = sti_cursor_destroy,
......
...@@ -140,7 +140,7 @@ static int sti_drm_dbg_init(struct drm_minor *minor) ...@@ -140,7 +140,7 @@ static int sti_drm_dbg_init(struct drm_minor *minor)
return ret; return ret;
} }
void sti_drm_dbg_cleanup(struct drm_minor *minor) static void sti_drm_dbg_cleanup(struct drm_minor *minor)
{ {
drm_debugfs_remove_files(sti_drm_dbg_list, drm_debugfs_remove_files(sti_drm_dbg_list,
ARRAY_SIZE(sti_drm_dbg_list), minor); ARRAY_SIZE(sti_drm_dbg_list), minor);
......
...@@ -17,6 +17,7 @@ ...@@ -17,6 +17,7 @@
#include <drm/drm_panel.h> #include <drm/drm_panel.h>
#include "sti_awg_utils.h" #include "sti_awg_utils.h"
#include "sti_drv.h"
#include "sti_mixer.h" #include "sti_mixer.h"
/* DVO registers */ /* DVO registers */
...@@ -106,7 +107,7 @@ struct sti_dvo_connector { ...@@ -106,7 +107,7 @@ struct sti_dvo_connector {
container_of(x, struct sti_dvo_connector, drm_connector) container_of(x, struct sti_dvo_connector, drm_connector)
#define BLANKING_LEVEL 16 #define BLANKING_LEVEL 16
int dvo_awg_generate_code(struct sti_dvo *dvo, u8 *ram_size, u32 *ram_code) static int dvo_awg_generate_code(struct sti_dvo *dvo, u8 *ram_size, u32 *ram_code)
{ {
struct drm_display_mode *mode = &dvo->mode; struct drm_display_mode *mode = &dvo->mode;
struct dvo_config *config = dvo->config; struct dvo_config *config = dvo->config;
......
...@@ -473,8 +473,8 @@ static void sti_gdp_disable(struct sti_gdp *gdp) ...@@ -473,8 +473,8 @@ static void sti_gdp_disable(struct sti_gdp *gdp)
* RETURNS: * RETURNS:
* 0 on success. * 0 on success.
*/ */
int sti_gdp_field_cb(struct notifier_block *nb, static int sti_gdp_field_cb(struct notifier_block *nb,
unsigned long event, void *data) unsigned long event, void *data)
{ {
struct sti_gdp *gdp = container_of(nb, struct sti_gdp, vtg_field_nb); struct sti_gdp *gdp = container_of(nb, struct sti_gdp, vtg_field_nb);
...@@ -882,7 +882,7 @@ static int sti_gdp_late_register(struct drm_plane *drm_plane) ...@@ -882,7 +882,7 @@ static int sti_gdp_late_register(struct drm_plane *drm_plane)
return gdp_debugfs_init(gdp, drm_plane->dev->primary); return gdp_debugfs_init(gdp, drm_plane->dev->primary);
} }
struct drm_plane_funcs sti_gdp_plane_helpers_funcs = { static const struct drm_plane_funcs sti_gdp_plane_helpers_funcs = {
.update_plane = drm_atomic_helper_update_plane, .update_plane = drm_atomic_helper_update_plane,
.disable_plane = drm_atomic_helper_disable_plane, .disable_plane = drm_atomic_helper_disable_plane,
.destroy = sti_gdp_destroy, .destroy = sti_gdp_destroy,
......
...@@ -17,6 +17,7 @@ ...@@ -17,6 +17,7 @@
#include "sti_hqvdp_lut.h" #include "sti_hqvdp_lut.h"
#include "sti_plane.h" #include "sti_plane.h"
#include "sti_vtg.h" #include "sti_vtg.h"
#include "sti_drv.h"
/* Firmware name */ /* Firmware name */
#define HQVDP_FMW_NAME "hqvdp-stih407.bin" #define HQVDP_FMW_NAME "hqvdp-stih407.bin"
...@@ -783,7 +784,7 @@ static void sti_hqvdp_disable(struct sti_hqvdp *hqvdp) ...@@ -783,7 +784,7 @@ static void sti_hqvdp_disable(struct sti_hqvdp *hqvdp)
* RETURNS: * RETURNS:
* 0 on success. * 0 on success.
*/ */
int sti_hqvdp_vtg_cb(struct notifier_block *nb, unsigned long evt, void *data) static int sti_hqvdp_vtg_cb(struct notifier_block *nb, unsigned long evt, void *data)
{ {
struct sti_hqvdp *hqvdp = container_of(nb, struct sti_hqvdp, vtg_nb); struct sti_hqvdp *hqvdp = container_of(nb, struct sti_hqvdp, vtg_nb);
int btm_cmd_offset, top_cmd_offest; int btm_cmd_offset, top_cmd_offest;
...@@ -1250,7 +1251,7 @@ static int sti_hqvdp_late_register(struct drm_plane *drm_plane) ...@@ -1250,7 +1251,7 @@ static int sti_hqvdp_late_register(struct drm_plane *drm_plane)
return hqvdp_debugfs_init(hqvdp, drm_plane->dev->primary); return hqvdp_debugfs_init(hqvdp, drm_plane->dev->primary);
} }
struct drm_plane_funcs sti_hqvdp_plane_helpers_funcs = { static const struct drm_plane_funcs sti_hqvdp_plane_helpers_funcs = {
.update_plane = drm_atomic_helper_update_plane, .update_plane = drm_atomic_helper_update_plane,
.disable_plane = drm_atomic_helper_disable_plane, .disable_plane = drm_atomic_helper_disable_plane,
.destroy = sti_hqvdp_destroy, .destroy = sti_hqvdp_destroy,
...@@ -1289,7 +1290,7 @@ static struct drm_plane *sti_hqvdp_create(struct drm_device *drm_dev, ...@@ -1289,7 +1290,7 @@ static struct drm_plane *sti_hqvdp_create(struct drm_device *drm_dev,
return &hqvdp->plane.drm_plane; return &hqvdp->plane.drm_plane;
} }
int sti_hqvdp_bind(struct device *dev, struct device *master, void *data) static int sti_hqvdp_bind(struct device *dev, struct device *master, void *data)
{ {
struct sti_hqvdp *hqvdp = dev_get_drvdata(dev); struct sti_hqvdp *hqvdp = dev_get_drvdata(dev);
struct drm_device *drm_dev = data; struct drm_device *drm_dev = data;
......
...@@ -358,7 +358,7 @@ int sti_mixer_set_plane_status(struct sti_mixer *mixer, ...@@ -358,7 +358,7 @@ int sti_mixer_set_plane_status(struct sti_mixer *mixer,
return 0; return 0;
} }
void sti_mixer_set_matrix(struct sti_mixer *mixer) static void sti_mixer_set_matrix(struct sti_mixer *mixer)
{ {
unsigned int i; unsigned int i;
......
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
#include <drm/drm_crtc_helper.h> #include <drm/drm_crtc_helper.h>
#include "sti_crtc.h" #include "sti_crtc.h"
#include "sti_drv.h"
#include "sti_vtg.h" #include "sti_vtg.h"
/* glue registers */ /* glue registers */
......
...@@ -12,6 +12,8 @@ ...@@ -12,6 +12,8 @@
#include <drm/drmP.h> #include <drm/drmP.h>
#include "sti_drv.h"
/* registers offset */ /* registers offset */
#define VTAC_CONFIG 0x00 #define VTAC_CONFIG 0x00
#define VTAC_RX_FIFO_CONFIG 0x04 #define VTAC_RX_FIFO_CONFIG 0x04
......
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include <drm/drmP.h> #include <drm/drmP.h>
#include "sti_drv.h"
#include "sti_vtg.h" #include "sti_vtg.h"
#define VTG_MODE_MASTER 0 #define VTG_MODE_MASTER 0
...@@ -72,7 +73,7 @@ ...@@ -72,7 +73,7 @@
#define AWG_DELAY_ED (-8) #define AWG_DELAY_ED (-8)
#define AWG_DELAY_SD (-7) #define AWG_DELAY_SD (-7)
LIST_HEAD(vtg_lookup); static LIST_HEAD(vtg_lookup);
/* /*
* STI VTG register offset structure * STI VTG register offset structure
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment