Commit be59d57f authored by Colin Ian King's avatar Colin Ian King Committed by Ingo Molnar

efi/tpm: Fix sanity check of unsigned tbl_size being less than zero

Currently the check for tbl_size being less than zero is always false
because tbl_size is unsigned. Fix this by making it a signed int.

Addresses-Coverity: ("Unsigned compared against 0")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Cc: linux-efi@vger.kernel.org
Fixes: e658c82b ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing")
Link: https://lkml.kernel.org/r/20191008100153.8499-1-colin.king@canonical.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 2ecb7402
...@@ -40,7 +40,7 @@ int __init efi_tpm_eventlog_init(void) ...@@ -40,7 +40,7 @@ int __init efi_tpm_eventlog_init(void)
{ {
struct linux_efi_tpm_eventlog *log_tbl; struct linux_efi_tpm_eventlog *log_tbl;
struct efi_tcg2_final_events_table *final_tbl; struct efi_tcg2_final_events_table *final_tbl;
unsigned int tbl_size; int tbl_size;
int ret = 0; int ret = 0;
if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) { if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment