Commit becddba9 authored by James Hogan's avatar James Hogan Committed by Ralf Baechle

MIPS: Correct forced syscall errors

When the system call return value is forced to be an error (for example
due to SECCOMP_RET_ERRNO), syscall_set_return_value() puts the error
code in the return register $v0 and -1 in the error register $a3.

However normally executed system calls put 1 in the error register
rather than -1, so fix syscall_set_return_value() to be consistent with
that.

I don't anticipate that anything would have been broken by this, since
the most natural way to check the error register on MIPS would be a
conditional branch if error register is [not] equal to zero (bnez or
beqz).

Fixes: 1d7bf993 ("MIPS: ftrace: Add support for syscall tracepoints.")
Signed-off-by: default avatarJames Hogan <james.hogan@imgtec.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/16652/Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
parent 4f32a39d
...@@ -85,7 +85,7 @@ static inline void syscall_set_return_value(struct task_struct *task, ...@@ -85,7 +85,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
{ {
if (error) { if (error) {
regs->regs[2] = -error; regs->regs[2] = -error;
regs->regs[7] = -1; regs->regs[7] = 1;
} else { } else {
regs->regs[2] = val; regs->regs[2] = val;
regs->regs[7] = 0; regs->regs[7] = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment