Commit bf16e5b8 authored by Eric Long's avatar Eric Long Committed by Greg Kroah-Hartman

coresight: "DEVICE_ATTR_RO" should defined as static.

"DEVICE_ATTR_RO(name)" should be defined as static. And
there is an unnecessary space at the front of the code.

The sparse tool output logs as the following:
coresight-etm4x.c:2224:1: warning: symbol 'dev_attr_trcoslsr' was
not declared. Should it be static?
coresight-etm4x.c:2225:1: warning: symbol 'dev_attr_trcpdcr' was
not declared. Should it be static?
coresight-etm4x.c:2226:1: warning: symbol 'dev_attr_trcpdsr' was
not declared. Should it be static?
And the smatch tool output logs as the following:
of_coresight.c:89 of_coresight_alloc_memory() warn:
inconsistent indenting
Signed-off-by: default avatarEric Long <eric.long@linaro.org>
Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent adcde635
...@@ -2227,7 +2227,7 @@ static ssize_t name##_show(struct device *_dev, \ ...@@ -2227,7 +2227,7 @@ static ssize_t name##_show(struct device *_dev, \
return scnprintf(buf, PAGE_SIZE, "0x%x\n", \ return scnprintf(buf, PAGE_SIZE, "0x%x\n", \
readl_relaxed(drvdata->base + offset)); \ readl_relaxed(drvdata->base + offset)); \
} \ } \
DEVICE_ATTR_RO(name) static DEVICE_ATTR_RO(name)
coresight_simple_func(trcoslsr, TRCOSLSR); coresight_simple_func(trcoslsr, TRCOSLSR);
coresight_simple_func(trcpdcr, TRCPDCR); coresight_simple_func(trcpdcr, TRCPDCR);
......
...@@ -86,7 +86,7 @@ static int of_coresight_alloc_memory(struct device *dev, ...@@ -86,7 +86,7 @@ static int of_coresight_alloc_memory(struct device *dev,
return -ENOMEM; return -ENOMEM;
/* Children connected to this component via @outports */ /* Children connected to this component via @outports */
pdata->child_names = devm_kzalloc(dev, pdata->nr_outport * pdata->child_names = devm_kzalloc(dev, pdata->nr_outport *
sizeof(*pdata->child_names), sizeof(*pdata->child_names),
GFP_KERNEL); GFP_KERNEL);
if (!pdata->child_names) if (!pdata->child_names)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment