Commit bf447221 authored by Colin Ian King's avatar Colin Ian King Committed by Mauro Carvalho Chehab

[media] c8sectpfe: fix ininitialized error return on firmware load failure

static analysis with cppcheck detected the following error:

[drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c:1210]:
  (error) Uninitialized variable: ret

ret is never initialised, so garbage is being returned. Instead
return the error return from the call of request_firmware_nowait
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
parent a9c4e5cf
...@@ -1192,7 +1192,6 @@ static void load_c8sectpfe_fw_cb(const struct firmware *fw, void *context) ...@@ -1192,7 +1192,6 @@ static void load_c8sectpfe_fw_cb(const struct firmware *fw, void *context)
static int load_c8sectpfe_fw_step1(struct c8sectpfei *fei) static int load_c8sectpfe_fw_step1(struct c8sectpfei *fei)
{ {
int ret;
int err; int err;
dev_info(fei->dev, "Loading firmware: %s\n", FIRMWARE_MEMDMA); dev_info(fei->dev, "Loading firmware: %s\n", FIRMWARE_MEMDMA);
...@@ -1207,7 +1206,7 @@ static int load_c8sectpfe_fw_step1(struct c8sectpfei *fei) ...@@ -1207,7 +1206,7 @@ static int load_c8sectpfe_fw_step1(struct c8sectpfei *fei)
if (err) { if (err) {
dev_err(fei->dev, "request_firmware_nowait err: %d.\n", err); dev_err(fei->dev, "request_firmware_nowait err: %d.\n", err);
complete_all(&fei->fw_ack); complete_all(&fei->fw_ack);
return ret; return err;
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment