Commit c0091073 authored by Marc Zyngier's avatar Marc Zyngier

KVM: arm64: vgic-its: Fix handling of indirect tables

The current code will fail on valid indirect tables, and happily
use the ones that are pointing out of the guest RAM. Funny what a
small "!" can do for you...
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent d97594e6
......@@ -702,9 +702,9 @@ static bool vgic_its_check_device_id(struct kvm *kvm, struct vgic_its *its,
return false;
/* Each 1st level entry is represented by a 64-bit value. */
if (!kvm_read_guest(kvm,
BASER_ADDRESS(r) + index * sizeof(indirect_ptr),
&indirect_ptr, sizeof(indirect_ptr)))
if (kvm_read_guest(kvm,
BASER_ADDRESS(r) + index * sizeof(indirect_ptr),
&indirect_ptr, sizeof(indirect_ptr)))
return false;
/* check the valid bit of the first level entry */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment