Commit c0981afd authored by Wambui Karuga's avatar Wambui Karuga Committed by Greg Kroah-Hartman

staging: kpc2000: Remove unnecessary return variable

Remove unnecessary variable `val` in kp_spi_read_reg() that only holds
the return value from readq().
Issue found by coccinelle using the script:

@@
local idexpression ret;
expression e;
@@

-ret =
+return
     e;
-return ret;
Signed-off-by: default avatarWambui Karuga <wambui.karugax@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Link: https://lore.kernel.org/r/20191009170703.GA2869@wambuiSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d49d1c76
...@@ -162,14 +162,12 @@ union kp_spi_ffctrl { ...@@ -162,14 +162,12 @@ union kp_spi_ffctrl {
kp_spi_read_reg(struct kp_spi_controller_state *cs, int idx) kp_spi_read_reg(struct kp_spi_controller_state *cs, int idx)
{ {
u64 __iomem *addr = cs->base; u64 __iomem *addr = cs->base;
u64 val;
addr += idx; addr += idx;
if ((idx == KP_SPI_REG_CONFIG) && (cs->conf_cache >= 0)) if ((idx == KP_SPI_REG_CONFIG) && (cs->conf_cache >= 0))
return cs->conf_cache; return cs->conf_cache;
val = readq(addr); return readq(addr);
return val;
} }
static inline void static inline void
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment