Commit c09dd7da authored by Jingoo Han's avatar Jingoo Han Committed by Anton Vorontsov

pcf50633-charger: Use devm_kzalloc()

Use devm_kzalloc() to make cleanup paths more simple.
Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarAnton Vorontsov <anton@enomsg.org>
parent b852ac51
...@@ -373,7 +373,7 @@ static int pcf50633_mbc_probe(struct platform_device *pdev) ...@@ -373,7 +373,7 @@ static int pcf50633_mbc_probe(struct platform_device *pdev)
int i; int i;
u8 mbcs1; u8 mbcs1;
mbc = kzalloc(sizeof(*mbc), GFP_KERNEL); mbc = devm_kzalloc(&pdev->dev, sizeof(*mbc), GFP_KERNEL);
if (!mbc) if (!mbc)
return -ENOMEM; return -ENOMEM;
...@@ -413,7 +413,6 @@ static int pcf50633_mbc_probe(struct platform_device *pdev) ...@@ -413,7 +413,6 @@ static int pcf50633_mbc_probe(struct platform_device *pdev)
ret = power_supply_register(&pdev->dev, &mbc->adapter); ret = power_supply_register(&pdev->dev, &mbc->adapter);
if (ret) { if (ret) {
dev_err(mbc->pcf->dev, "failed to register adapter\n"); dev_err(mbc->pcf->dev, "failed to register adapter\n");
kfree(mbc);
return ret; return ret;
} }
...@@ -421,7 +420,6 @@ static int pcf50633_mbc_probe(struct platform_device *pdev) ...@@ -421,7 +420,6 @@ static int pcf50633_mbc_probe(struct platform_device *pdev)
if (ret) { if (ret) {
dev_err(mbc->pcf->dev, "failed to register usb\n"); dev_err(mbc->pcf->dev, "failed to register usb\n");
power_supply_unregister(&mbc->adapter); power_supply_unregister(&mbc->adapter);
kfree(mbc);
return ret; return ret;
} }
...@@ -430,7 +428,6 @@ static int pcf50633_mbc_probe(struct platform_device *pdev) ...@@ -430,7 +428,6 @@ static int pcf50633_mbc_probe(struct platform_device *pdev)
dev_err(mbc->pcf->dev, "failed to register ac\n"); dev_err(mbc->pcf->dev, "failed to register ac\n");
power_supply_unregister(&mbc->adapter); power_supply_unregister(&mbc->adapter);
power_supply_unregister(&mbc->usb); power_supply_unregister(&mbc->usb);
kfree(mbc);
return ret; return ret;
} }
...@@ -461,8 +458,6 @@ static int pcf50633_mbc_remove(struct platform_device *pdev) ...@@ -461,8 +458,6 @@ static int pcf50633_mbc_remove(struct platform_device *pdev)
power_supply_unregister(&mbc->adapter); power_supply_unregister(&mbc->adapter);
power_supply_unregister(&mbc->ac); power_supply_unregister(&mbc->ac);
kfree(mbc);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment