Commit c0a52f8b authored by Jani Nikula's avatar Jani Nikula

drm/i915/backlight: mass rename functions to have intel_backlight_ prefix

Follow the usual naming conventions. As a drive-by cleanup, also pass
intel_connector instead of drm_connector to intel_backlight_setup(). No
functional changes.

Cc: Lyude Paul <lyude@redhat.com>
Reviewed-by: default avatarLyude Paul <lyude@redhat.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/ea1c22370210abdd4f5547af73c71b902061ea50.1629888677.git.jani.nikula@intel.com
parent 6cc42fbe
...@@ -1334,7 +1334,7 @@ bool g4x_dp_init(struct drm_i915_private *dev_priv, ...@@ -1334,7 +1334,7 @@ bool g4x_dp_init(struct drm_i915_private *dev_priv,
intel_encoder->get_config = intel_dp_get_config; intel_encoder->get_config = intel_dp_get_config;
intel_encoder->sync_state = intel_dp_sync_state; intel_encoder->sync_state = intel_dp_sync_state;
intel_encoder->initial_fastset_check = intel_dp_initial_fastset_check; intel_encoder->initial_fastset_check = intel_dp_initial_fastset_check;
intel_encoder->update_pipe = intel_panel_update_backlight; intel_encoder->update_pipe = intel_backlight_update;
intel_encoder->suspend = intel_dp_encoder_suspend; intel_encoder->suspend = intel_dp_encoder_suspend;
intel_encoder->shutdown = intel_dp_encoder_shutdown; intel_encoder->shutdown = intel_dp_encoder_shutdown;
if (IS_CHERRYVIEW(dev_priv)) { if (IS_CHERRYVIEW(dev_priv)) {
......
...@@ -1288,7 +1288,7 @@ static void gen11_dsi_enable(struct intel_atomic_state *state, ...@@ -1288,7 +1288,7 @@ static void gen11_dsi_enable(struct intel_atomic_state *state,
gen11_dsi_enable_transcoder(encoder); gen11_dsi_enable_transcoder(encoder);
/* step7: enable backlight */ /* step7: enable backlight */
intel_panel_enable_backlight(crtc_state, conn_state); intel_backlight_enable(crtc_state, conn_state);
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_ON); intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_ON);
intel_crtc_vblank_on(crtc_state); intel_crtc_vblank_on(crtc_state);
...@@ -1441,7 +1441,7 @@ static void gen11_dsi_disable(struct intel_atomic_state *state, ...@@ -1441,7 +1441,7 @@ static void gen11_dsi_disable(struct intel_atomic_state *state,
/* step1: turn off backlight */ /* step1: turn off backlight */
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_OFF); intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_OFF);
intel_panel_disable_backlight(old_conn_state); intel_backlight_disable(old_conn_state);
/* step2d,e: disable transcoder and wait */ /* step2d,e: disable transcoder and wait */
gen11_dsi_disable_transcoder(encoder); gen11_dsi_disable_transcoder(encoder);
...@@ -2009,7 +2009,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv) ...@@ -2009,7 +2009,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
encoder->port = port; encoder->port = port;
encoder->get_config = gen11_dsi_get_config; encoder->get_config = gen11_dsi_get_config;
encoder->sync_state = gen11_dsi_sync_state; encoder->sync_state = gen11_dsi_sync_state;
encoder->update_pipe = intel_panel_update_backlight; encoder->update_pipe = intel_backlight_update;
encoder->compute_config = gen11_dsi_compute_config; encoder->compute_config = gen11_dsi_compute_config;
encoder->get_hw_state = gen11_dsi_get_hw_state; encoder->get_hw_state = gen11_dsi_get_hw_state;
encoder->initial_fastset_check = gen11_dsi_initial_fastset_check; encoder->initial_fastset_check = gen11_dsi_initial_fastset_check;
...@@ -2043,7 +2043,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv) ...@@ -2043,7 +2043,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
} }
intel_panel_init(&intel_connector->panel, fixed_mode, NULL); intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
intel_panel_setup_backlight(connector, INVALID_PIPE); intel_backlight_setup(intel_connector, INVALID_PIPE);
if (dev_priv->vbt.dsi.config->dual_link) if (dev_priv->vbt.dsi.config->dual_link)
intel_dsi->ports = BIT(PORT_A) | BIT(PORT_B); intel_dsi->ports = BIT(PORT_A) | BIT(PORT_B);
......
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
#include <linux/types.h> #include <linux/types.h>
struct drm_connector;
struct drm_connector_state; struct drm_connector_state;
struct intel_atomic_state; struct intel_atomic_state;
struct intel_connector; struct intel_connector;
...@@ -17,23 +16,25 @@ struct intel_encoder; ...@@ -17,23 +16,25 @@ struct intel_encoder;
struct intel_panel; struct intel_panel;
enum pipe; enum pipe;
void intel_panel_init_backlight_funcs(struct intel_panel *panel); void intel_backlight_init_funcs(struct intel_panel *panel);
void intel_panel_destroy_backlight(struct intel_panel *panel); int intel_backlight_setup(struct intel_connector *connector, enum pipe pipe);
void intel_panel_set_backlight_acpi(const struct drm_connector_state *conn_state, void intel_backlight_destroy(struct intel_panel *panel);
u32 level, u32 max);
int intel_panel_setup_backlight(struct drm_connector *connector, void intel_backlight_enable(const struct intel_crtc_state *crtc_state,
enum pipe pipe); const struct drm_connector_state *conn_state);
void intel_panel_enable_backlight(const struct intel_crtc_state *crtc_state, void intel_backlight_update(struct intel_atomic_state *state,
const struct drm_connector_state *conn_state); struct intel_encoder *encoder,
void intel_panel_update_backlight(struct intel_atomic_state *state, const struct intel_crtc_state *crtc_state,
struct intel_encoder *encoder, const struct drm_connector_state *conn_state);
const struct intel_crtc_state *crtc_state, void intel_backlight_disable(const struct drm_connector_state *old_conn_state);
const struct drm_connector_state *conn_state);
void intel_panel_disable_backlight(const struct drm_connector_state *old_conn_state); void intel_backlight_set_acpi(const struct drm_connector_state *conn_state,
void intel_panel_set_pwm_level(const struct drm_connector_state *conn_state, u32 level); u32 level, u32 max);
u32 intel_panel_invert_pwm_level(struct intel_connector *connector, u32 level); void intel_backlight_set_pwm_level(const struct drm_connector_state *conn_state,
u32 intel_panel_backlight_level_to_pwm(struct intel_connector *connector, u32 level); u32 level);
u32 intel_panel_backlight_level_from_pwm(struct intel_connector *connector, u32 val); u32 intel_backlight_invert_pwm_level(struct intel_connector *connector, u32 level);
u32 intel_backlight_level_to_pwm(struct intel_connector *connector, u32 level);
u32 intel_backlight_level_from_pwm(struct intel_connector *connector, u32 val);
#if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) #if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)
int intel_backlight_device_register(struct intel_connector *connector); int intel_backlight_device_register(struct intel_connector *connector);
......
...@@ -3234,7 +3234,7 @@ static void intel_ddi_update_pipe_dp(struct intel_atomic_state *state, ...@@ -3234,7 +3234,7 @@ static void intel_ddi_update_pipe_dp(struct intel_atomic_state *state,
intel_dp_set_infoframes(encoder, true, crtc_state, conn_state); intel_dp_set_infoframes(encoder, true, crtc_state, conn_state);
intel_edp_drrs_update(intel_dp, crtc_state); intel_edp_drrs_update(intel_dp, crtc_state);
intel_panel_update_backlight(state, encoder, crtc_state, conn_state); intel_backlight_update(state, encoder, crtc_state, conn_state);
} }
void intel_ddi_update_pipe(struct intel_atomic_state *state, void intel_ddi_update_pipe(struct intel_atomic_state *state,
......
...@@ -1852,7 +1852,7 @@ void intel_edp_backlight_on(const struct intel_crtc_state *crtc_state, ...@@ -1852,7 +1852,7 @@ void intel_edp_backlight_on(const struct intel_crtc_state *crtc_state,
drm_dbg_kms(&i915->drm, "\n"); drm_dbg_kms(&i915->drm, "\n");
intel_panel_enable_backlight(crtc_state, conn_state); intel_backlight_enable(crtc_state, conn_state);
intel_pps_backlight_on(intel_dp); intel_pps_backlight_on(intel_dp);
} }
...@@ -1868,7 +1868,7 @@ void intel_edp_backlight_off(const struct drm_connector_state *old_conn_state) ...@@ -1868,7 +1868,7 @@ void intel_edp_backlight_off(const struct drm_connector_state *old_conn_state)
drm_dbg_kms(&i915->drm, "\n"); drm_dbg_kms(&i915->drm, "\n");
intel_pps_backlight_off(intel_dp); intel_pps_backlight_off(intel_dp);
intel_panel_disable_backlight(old_conn_state); intel_backlight_disable(old_conn_state);
} }
static bool downstream_hpd_needs_d0(struct intel_dp *intel_dp) static bool downstream_hpd_needs_d0(struct intel_dp *intel_dp)
...@@ -5303,7 +5303,7 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp, ...@@ -5303,7 +5303,7 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,
intel_panel_init(&intel_connector->panel, fixed_mode, downclock_mode); intel_panel_init(&intel_connector->panel, fixed_mode, downclock_mode);
if (!(dev_priv->quirks & QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK)) if (!(dev_priv->quirks & QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK))
intel_connector->panel.backlight.power = intel_pps_backlight_power; intel_connector->panel.backlight.power = intel_pps_backlight_power;
intel_panel_setup_backlight(connector, pipe); intel_backlight_setup(intel_connector, pipe);
if (fixed_mode) { if (fixed_mode) {
drm_connector_set_panel_orientation_with_quirk(connector, drm_connector_set_panel_orientation_with_quirk(connector,
......
...@@ -146,7 +146,7 @@ intel_dp_aux_hdr_get_backlight(struct intel_connector *connector, enum pipe pipe ...@@ -146,7 +146,7 @@ intel_dp_aux_hdr_get_backlight(struct intel_connector *connector, enum pipe pipe
if (!panel->backlight.edp.intel.sdr_uses_aux) { if (!panel->backlight.edp.intel.sdr_uses_aux) {
u32 pwm_level = panel->backlight.pwm_funcs->get(connector, pipe); u32 pwm_level = panel->backlight.pwm_funcs->get(connector, pipe);
return intel_panel_backlight_level_from_pwm(connector, pwm_level); return intel_backlight_level_from_pwm(connector, pwm_level);
} }
/* Assume 100% brightness if backlight controls aren't enabled yet */ /* Assume 100% brightness if backlight controls aren't enabled yet */
...@@ -187,9 +187,9 @@ intel_dp_aux_hdr_set_backlight(const struct drm_connector_state *conn_state, u32 ...@@ -187,9 +187,9 @@ intel_dp_aux_hdr_set_backlight(const struct drm_connector_state *conn_state, u32
if (panel->backlight.edp.intel.sdr_uses_aux) { if (panel->backlight.edp.intel.sdr_uses_aux) {
intel_dp_aux_hdr_set_aux_backlight(conn_state, level); intel_dp_aux_hdr_set_aux_backlight(conn_state, level);
} else { } else {
const u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level); const u32 pwm_level = intel_backlight_level_to_pwm(connector, level);
intel_panel_set_pwm_level(conn_state, pwm_level); intel_backlight_set_pwm_level(conn_state, pwm_level);
} }
} }
...@@ -215,7 +215,7 @@ intel_dp_aux_hdr_enable_backlight(const struct intel_crtc_state *crtc_state, ...@@ -215,7 +215,7 @@ intel_dp_aux_hdr_enable_backlight(const struct intel_crtc_state *crtc_state,
ctrl |= INTEL_EDP_HDR_TCON_BRIGHTNESS_AUX_ENABLE; ctrl |= INTEL_EDP_HDR_TCON_BRIGHTNESS_AUX_ENABLE;
intel_dp_aux_hdr_set_aux_backlight(conn_state, level); intel_dp_aux_hdr_set_aux_backlight(conn_state, level);
} else { } else {
u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level); u32 pwm_level = intel_backlight_level_to_pwm(connector, level);
panel->backlight.pwm_funcs->enable(crtc_state, conn_state, pwm_level); panel->backlight.pwm_funcs->enable(crtc_state, conn_state, pwm_level);
...@@ -238,7 +238,7 @@ intel_dp_aux_hdr_disable_backlight(const struct drm_connector_state *conn_state, ...@@ -238,7 +238,7 @@ intel_dp_aux_hdr_disable_backlight(const struct drm_connector_state *conn_state,
return; return;
/* Note we want the actual pwm_level to be 0, regardless of pwm_min */ /* Note we want the actual pwm_level to be 0, regardless of pwm_min */
panel->backlight.pwm_funcs->disable(conn_state, intel_panel_invert_pwm_level(connector, 0)); panel->backlight.pwm_funcs->disable(conn_state, intel_backlight_invert_pwm_level(connector, 0));
} }
static int static int
......
...@@ -324,7 +324,7 @@ static void intel_enable_lvds(struct intel_atomic_state *state, ...@@ -324,7 +324,7 @@ static void intel_enable_lvds(struct intel_atomic_state *state,
drm_err(&dev_priv->drm, drm_err(&dev_priv->drm,
"timed out waiting for panel to power on\n"); "timed out waiting for panel to power on\n");
intel_panel_enable_backlight(pipe_config, conn_state); intel_backlight_enable(pipe_config, conn_state);
} }
static void intel_disable_lvds(struct intel_atomic_state *state, static void intel_disable_lvds(struct intel_atomic_state *state,
...@@ -352,7 +352,7 @@ static void gmch_disable_lvds(struct intel_atomic_state *state, ...@@ -352,7 +352,7 @@ static void gmch_disable_lvds(struct intel_atomic_state *state,
const struct drm_connector_state *old_conn_state) const struct drm_connector_state *old_conn_state)
{ {
intel_panel_disable_backlight(old_conn_state); intel_backlight_disable(old_conn_state);
intel_disable_lvds(state, encoder, old_crtc_state, old_conn_state); intel_disable_lvds(state, encoder, old_crtc_state, old_conn_state);
} }
...@@ -362,7 +362,7 @@ static void pch_disable_lvds(struct intel_atomic_state *state, ...@@ -362,7 +362,7 @@ static void pch_disable_lvds(struct intel_atomic_state *state,
const struct intel_crtc_state *old_crtc_state, const struct intel_crtc_state *old_crtc_state,
const struct drm_connector_state *old_conn_state) const struct drm_connector_state *old_conn_state)
{ {
intel_panel_disable_backlight(old_conn_state); intel_backlight_disable(old_conn_state);
} }
static void pch_post_disable_lvds(struct intel_atomic_state *state, static void pch_post_disable_lvds(struct intel_atomic_state *state,
...@@ -907,7 +907,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv) ...@@ -907,7 +907,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
} }
intel_encoder->get_hw_state = intel_lvds_get_hw_state; intel_encoder->get_hw_state = intel_lvds_get_hw_state;
intel_encoder->get_config = intel_lvds_get_config; intel_encoder->get_config = intel_lvds_get_config;
intel_encoder->update_pipe = intel_panel_update_backlight; intel_encoder->update_pipe = intel_backlight_update;
intel_encoder->shutdown = intel_lvds_shutdown; intel_encoder->shutdown = intel_lvds_shutdown;
intel_connector->get_hw_state = intel_connector_get_hw_state; intel_connector->get_hw_state = intel_connector_get_hw_state;
...@@ -1000,7 +1000,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv) ...@@ -1000,7 +1000,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
mutex_unlock(&dev->mode_config.mutex); mutex_unlock(&dev->mode_config.mutex);
intel_panel_init(&intel_connector->panel, fixed_mode, downclock_mode); intel_panel_init(&intel_connector->panel, fixed_mode, downclock_mode);
intel_panel_setup_backlight(connector, INVALID_PIPE); intel_backlight_setup(intel_connector, INVALID_PIPE);
lvds_encoder->is_dual_link = compute_is_dual_link_lvds(lvds_encoder); lvds_encoder->is_dual_link = compute_is_dual_link_lvds(lvds_encoder);
drm_dbg_kms(&dev_priv->drm, "detected %s-link lvds configuration\n", drm_dbg_kms(&dev_priv->drm, "detected %s-link lvds configuration\n",
......
...@@ -449,7 +449,7 @@ static u32 asle_set_backlight(struct drm_i915_private *dev_priv, u32 bclp) ...@@ -449,7 +449,7 @@ static u32 asle_set_backlight(struct drm_i915_private *dev_priv, u32 bclp)
bclp); bclp);
drm_connector_list_iter_begin(dev, &conn_iter); drm_connector_list_iter_begin(dev, &conn_iter);
for_each_intel_connector_iter(connector, &conn_iter) for_each_intel_connector_iter(connector, &conn_iter)
intel_panel_set_backlight_acpi(connector->base.state, bclp, 255); intel_backlight_set_acpi(connector->base.state, bclp, 255);
drm_connector_list_iter_end(&conn_iter); drm_connector_list_iter_end(&conn_iter);
asle->cblv = DIV_ROUND_UP(bclp * 100, 255) | ASLE_CBLV_VALID; asle->cblv = DIV_ROUND_UP(bclp * 100, 255) | ASLE_CBLV_VALID;
......
...@@ -475,7 +475,7 @@ int intel_panel_init(struct intel_panel *panel, ...@@ -475,7 +475,7 @@ int intel_panel_init(struct intel_panel *panel,
struct drm_display_mode *fixed_mode, struct drm_display_mode *fixed_mode,
struct drm_display_mode *downclock_mode) struct drm_display_mode *downclock_mode)
{ {
intel_panel_init_backlight_funcs(panel); intel_backlight_init_funcs(panel);
panel->fixed_mode = fixed_mode; panel->fixed_mode = fixed_mode;
panel->downclock_mode = downclock_mode; panel->downclock_mode = downclock_mode;
...@@ -488,7 +488,7 @@ void intel_panel_fini(struct intel_panel *panel) ...@@ -488,7 +488,7 @@ void intel_panel_fini(struct intel_panel *panel)
struct intel_connector *intel_connector = struct intel_connector *intel_connector =
container_of(panel, struct intel_connector, panel); container_of(panel, struct intel_connector, panel);
intel_panel_destroy_backlight(panel); intel_backlight_destroy(panel);
if (panel->fixed_mode) if (panel->fixed_mode)
drm_mode_destroy(intel_connector->base.dev, panel->fixed_mode); drm_mode_destroy(intel_connector->base.dev, panel->fixed_mode);
......
...@@ -884,7 +884,7 @@ static void intel_dsi_pre_enable(struct intel_atomic_state *state, ...@@ -884,7 +884,7 @@ static void intel_dsi_pre_enable(struct intel_atomic_state *state,
intel_dsi_port_enable(encoder, pipe_config); intel_dsi_port_enable(encoder, pipe_config);
} }
intel_panel_enable_backlight(pipe_config, conn_state); intel_backlight_enable(pipe_config, conn_state);
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_ON); intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_ON);
} }
...@@ -914,7 +914,7 @@ static void intel_dsi_disable(struct intel_atomic_state *state, ...@@ -914,7 +914,7 @@ static void intel_dsi_disable(struct intel_atomic_state *state,
drm_dbg_kms(&i915->drm, "\n"); drm_dbg_kms(&i915->drm, "\n");
intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_OFF); intel_dsi_vbt_exec_sequence(intel_dsi, MIPI_SEQ_BACKLIGHT_OFF);
intel_panel_disable_backlight(old_conn_state); intel_backlight_disable(old_conn_state);
/* /*
* According to the spec we should send SHUTDOWN before * According to the spec we should send SHUTDOWN before
...@@ -1877,7 +1877,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv) ...@@ -1877,7 +1877,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv)
intel_encoder->post_disable = intel_dsi_post_disable; intel_encoder->post_disable = intel_dsi_post_disable;
intel_encoder->get_hw_state = intel_dsi_get_hw_state; intel_encoder->get_hw_state = intel_dsi_get_hw_state;
intel_encoder->get_config = intel_dsi_get_config; intel_encoder->get_config = intel_dsi_get_config;
intel_encoder->update_pipe = intel_panel_update_backlight; intel_encoder->update_pipe = intel_backlight_update;
intel_encoder->shutdown = intel_dsi_shutdown; intel_encoder->shutdown = intel_dsi_shutdown;
intel_connector->get_hw_state = intel_connector_get_hw_state; intel_connector->get_hw_state = intel_connector_get_hw_state;
...@@ -1965,7 +1965,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv) ...@@ -1965,7 +1965,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv)
} }
intel_panel_init(&intel_connector->panel, fixed_mode, NULL); intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
intel_panel_setup_backlight(connector, INVALID_PIPE); intel_backlight_setup(intel_connector, INVALID_PIPE);
vlv_dsi_add_properties(intel_connector); vlv_dsi_add_properties(intel_connector);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment