Commit c0d5f9db authored by Jim Schutt's avatar Jim Schutt Committed by Sage Weil

libceph: initialize ack_stamp to avoid unnecessary connection reset

Commit 4cf9d544 recorded when an outgoing ceph message was ACKed,
in order to avoid unnecessary connection resets when an OSD is busy.

However, ack_stamp is uninitialized, so there is a window between
when the message is sent and when it is ACKed in which handle_timeout()
interprets the unitialized value as an expired timeout, and resets
the connection unnecessarily.

Close the window by initializing ack_stamp.
Signed-off-by: default avatarJim Schutt <jaschut@sandia.gov>
Signed-off-by: default avatarSage Weil <sage@newdream.net>
parent aca420bc
...@@ -2307,6 +2307,7 @@ struct ceph_msg *ceph_msg_new(int type, int front_len, gfp_t flags) ...@@ -2307,6 +2307,7 @@ struct ceph_msg *ceph_msg_new(int type, int front_len, gfp_t flags)
m->front_max = front_len; m->front_max = front_len;
m->front_is_vmalloc = false; m->front_is_vmalloc = false;
m->more_to_follow = false; m->more_to_follow = false;
m->ack_stamp = 0;
m->pool = NULL; m->pool = NULL;
/* middle */ /* middle */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment