Commit c1a357b6 authored by Johan Hovold's avatar Johan Hovold

USB: serial: garmin_gps: clean up init-session messages

Use the port device for any init-session error and debug messages,
remove one redundant debug message and simplify one error message.
Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent b943cee8
...@@ -876,7 +876,6 @@ static int garmin_clear(struct garmin_data *garmin_data_p) ...@@ -876,7 +876,6 @@ static int garmin_clear(struct garmin_data *garmin_data_p)
static int garmin_init_session(struct usb_serial_port *port) static int garmin_init_session(struct usb_serial_port *port)
{ {
struct usb_serial *serial = port->serial;
struct garmin_data *garmin_data_p = usb_get_serial_port_data(port); struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
int status = 0; int status = 0;
int i = 0; int i = 0;
...@@ -884,12 +883,12 @@ static int garmin_init_session(struct usb_serial_port *port) ...@@ -884,12 +883,12 @@ static int garmin_init_session(struct usb_serial_port *port)
if (status == 0) { if (status == 0) {
usb_kill_urb(port->interrupt_in_urb); usb_kill_urb(port->interrupt_in_urb);
dev_dbg(&serial->dev->dev, "%s - adding interrupt input\n", __func__);
status = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); status = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
if (status) if (status) {
dev_err(&serial->dev->dev, dev_err(&port->dev,
"%s - failed submitting interrupt urb, error %d\n", "failed to submit interrupt urb: %d\n",
__func__, status); status);
}
} }
/* /*
...@@ -897,7 +896,7 @@ static int garmin_init_session(struct usb_serial_port *port) ...@@ -897,7 +896,7 @@ static int garmin_init_session(struct usb_serial_port *port)
* gpsbabel/jeeps/gpslibusb.c gusb_reset_toggles() * gpsbabel/jeeps/gpslibusb.c gusb_reset_toggles()
*/ */
if (status == 0) { if (status == 0) {
dev_dbg(&serial->dev->dev, "%s - starting session ...\n", __func__); dev_dbg(&port->dev, "%s - starting session ...\n", __func__);
garmin_data_p->state = STATE_ACTIVE; garmin_data_p->state = STATE_ACTIVE;
for (i = 0; i < 3; i++) { for (i = 0; i < 3; i++) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment